Closed Bug 198118 Opened 21 years ago Closed 20 years ago

Support nsIAccessible::getKeyboardShortcut for xul:textbox

Categories

(Core :: Disability Access APIs, defect, P1)

Other Branch
x86
Windows XP
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dsirnapalli, Assigned: aaronlev)

References

Details

(Keywords: access)

Attachments

(1 file, 2 obsolete files)

Test case attached.
I am able to reproduce this bug on Mozilla 1.2(Gecko/20021126), WinXP.
nsIAccessible's accKeyboardShortcut is returning empty string as keyboard
shortcut for xultextbox node..
I will try to reproduce this on other builds and update the bug.
Previously this test case was working fine. I was able to get shortcut.
Attached file Testcase to reproduce the bug.. (obsolete) —
Keywords: access
Priority: -- → P3
Summary: nsIAccessible's accKeyboardShortcut is not returning keyboard shortcut for xultextbox node.. → Support s accKeyboardShortcut for xul:textbox
I think the problem is get getKeyboardShortcut doesn't look to see if there's an
accesskey on the <label control="foo"> for the element.

We have code to look for the label in GetXULName().
Blocks: atfmeta
Summary: Support s accKeyboardShortcut for xul:textbox → Support nsIAccessible::getKeyboardShortcut for xul:textbox
Priority: P3 → P1
It seems to work, but I want to clean it up and test more.
Attachment #117659 - Attachment is obsolete: true
Attachment #151046 - Attachment is obsolete: true
Comment on attachment 151116 [details] [diff] [review]
Use GetHTMLLabel() and GetXULLabel() to return label nodes so we can get name or accesskey from it

To test with HTML: use
http://bugzilla.mozilla.org/attachment.cgi?id=133361&action=view

To test in XUL: try the loc_a_tion edit box in Prefs->Navigator
Attachment #151116 - Flags: review?(Louie.Zhao)
Attachment #151116 - Flags: review?(Louie.Zhao) → review+
Attachment #151116 - Flags: superreview?(Henry.Jia)
Attachment #151116 - Flags: superreview?(Henry.Jia) → superreview+
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <-- 
nsAccessibilityAtomList.h
new revision: 1.6; previous revision: 1.5
done
Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.110; previous revision: 1.109
done
Checking in accessible/src/base/nsAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsAccessible.h,v  <--  nsAccessible.h
new revision: 1.49; previous revision: 1.48
done
Checking in accessible/src/xul/nsXULSelectAccessible.h;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.h,v  <-- 
nsXULSelectAccessible.h
new revision: 1.17; previous revision: 1.16
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: