198462 - Get LDAP to build on OpenBSD

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[timeless]

Comment 1

[timeless]

Attachment: patch

Comment 2

[Mark Smith [:mcs]]

Comment on attachment 117894 [details] [diff] [review]
patch

Patch looks OK to me. I assume c_r is no longer relevant (included by the
linker automatically or part of libc now?)

Comment 3

[Mark Smith [:mcs]]

Do you need this committed to the branch or just the trunk? I assume you need it
on the LDAP branch that is used by the Mozilla client
(ldapcsdk_50_client_branch) , which means we need a superreview.

Comment 4

[timeless]

Comment on attachment 117894 [details] [diff] [review]
patch

re c_r, [e-mail]?

yes at least where mozilla is using it, and i guess trunk so that when mozilla
moves to a new branch we don't have to ask again.

thanks

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 117894 [details] [diff] [review]
patch

sr=dmose

Comment 6

[rich cannings]

yes libc_r has been superseded by libpthread. however it has come to my
attention that I should be using -pthread rather than -lpthread. I will try
recompiling and testing with -pthread, but it takes almost a day to do the build
before I test.

rich

Comment 7

[Frankie]

Spam for bug 129472

Comment 8

[rich cannings]

Attachment: updated for -pthread rather than -lpthread

This is a replacement patch for the initial patch. It runs very well and is the
"correct" way to use pthreads.

I think we can close this bug now.

Comment 9

[Mark Smith [:mcs]]

Comment on attachment 119353 [details] [diff] [review]
updated for -pthread rather than -lpthread

OK.

Comment 10

[David Krause]

what needs to happen to get this into 1.4 beta?  superreview?

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 119353 [details] [diff] [review]
updated for -pthread rather than -lpthread

sr=dmose

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 119353 [details] [diff] [review]
updated for -pthread rather than -lpthread

this is a one-line patch to let LDAP build on OpenBSD... does not affect other
platforms. would be nice to get into 1.4beta.

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 119353 [details] [diff] [review]
updated for -pthread rather than -lpthread

a=mkaply for 1.4b

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Checked in on ldapcsdk_50_client_branch

Checking in directory/c-sdk/ldap/libraries/libldap/Makefile.in;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/Makefile.in,v  <-- 
Makefile.in
new revision: 5.0.2.19; previous revision: 5.0.2.18
done

-> dmose for LDAP C-SDK Trunk checkin

Comment 15

[cls]

Checking in directory/c-sdk/ldap/libraries/libldap/Makefile.in;
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libldap/Makefile.in,v  <-- 
Makefile.in
new revision: 5.13; previous revision: 5.12
done