198909 - [local mail] Can't undo a delete until Trash has its .msf file built.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

[local mail] Can't undo a delete until Trash has its .msf file built.

debugging now...

Comment 1

[(not reading, please use [e-mail] instead)]

...ok, back to debugging.

accepting, I can reproduce this (easily).

Comment 2

[(not reading, please use [e-mail] instead)]

this was a purposeful change to nsMsgLocalMailFolder::EndCopy()

mCopyState->m_undoMsgTxn = nsnull; //null out the transaction because we can't
undo w/o the msg db]

I'll go find the bug #, and see what I can do about it.

Comment 3

[(not reading, please use [e-mail] instead)]

this changed back on 9/11/2002, with a checkin for bug #166411:

"Copying msgs to local folders with invalid db's causes corruption"

working on a fix so that when we call delete messages (of a type that moves to
trash and where undo is supposed to be enabled), we ensure the trash database
(.msf) is there.

trying to decide if the fix should be generalized

(move message from inbox to folder xyz, where xyz doesn't have a .msf file yet,
undo would also be unavailable.)

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 6

[(not reading, please use [e-mail] instead)]

here's the basic idea to this patch:

on undo, if we need to parse, we parse and then do the undo work after the
destination folder (trash, in this case) is loaded.

this makes sure that the .msf is built, so that when we do the undo work.

if we don't need to reparse, we just do what we used to do.

I'll talk this all over with bienvenu, see what he thinks.

Comment 7

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 8

[(not reading, please use [e-mail] instead)]

talked it over bienvenu, and he suggested something different, and I've got a
patch started.

Comment 9

[David :Bienvenu]

*** Bug 175899 has been marked as a duplicate of this bug. ***

Comment 10

[Aleksey Nogin]

I also see this with IMAP, when .msf is there, but was not loaded yet (see also
the dup bug 175899)

Comment 11

[(not reading, please use [e-mail] instead)]

over to david, I'll attach the patch I've started.

Comment 12

[David :Bienvenu]

this was fixed (I think under another bug)

Comment 13

[esther]

Using trunk build 2003059 on winxp, macosx and linux this is fixed. Verified.