199085 - Add "Character Encoding" menu

Status: RESOLVED WORKSFORME

(Other Applications :: ChatZilla, enhancement)

Description

[Koike Kazuhiko]

Chatzilla should have "Character Coding" menu.

Related: bug 198823

Comment 1

[Koike Kazuhiko]

Attachment: patch v1

This patch has to be modified if bug 119746 is fixed.

Comment 2

[Prognathous]

Now that bug 119746 was fixed, is there any chance of modifying this patch and
landing it in 1.4/final?

Thanks,

Prog.

Comment 3

[Robert Ginda]

Comment on attachment 118389 [details] [diff] [review]
patch v1

I don't like the idea that we have to modify something in content/global for
this change.  I'd really rather not do that.

Comment 4

[Prognathous]

Changing "Coding" in the summary to "Encoding", the term currently used in Mozilla.

Prog.

Comment 5

[a_ber]

The patch is probably works, but still not landed on version and the Chatzilla
is lack the ability to change the encoding manually, which prevents the usage of
it in non-Latin based languages

Comment 6

[Samuel Sieb]

What do you mean it "lack the ability to change the encoding manually"?  Have
you checked the /charset command?  See Bug 119746 for more details.

Comment 7

[:Gijs (he/him)]

I think the /charset command and the preference window for character sets,
specifically for changing the character set on a per-server or even per-channel
basis are perfectly okay. 
If you do want such a menu, you'd have to wonder what it would set, the global
character set, or only that for the current channel or network.

Comment 8

[James Ross]

The menus are a bit messy on the global/view front. I think a Charset menu would
be possible to do, and /might/ be useful, but on the other hand, you should not
need to change charset more than once per view, normally.

Comment 9

[:Gijs (he/him)]

Comment on attachment 118389 [details] [diff] [review]
patch v1

Minusing this really old patch because it probably doesn't apply cleanly anymore (at all), and if it did it does not work for Firefox, Flock or XULRunner - and soon it might stop working for SeaMonkey when they switch to SuiteRunner, though I'm admittedly less sure about that.

Comment 10

[Stéphane Grégoire (yamo)]

There's a charset menu on Chatzilla 0.9.87. Is this bug fixed?

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to Stéphane Grégoire (yamo) from comment #10)
> There's a charset menu on Chatzilla 0.9.87. Is this bug fixed?

There is indeed a prominent "Character Encoding" input box on the General tab of:
- the Global Settings prefs page
- each network prefs page
- each channel prefs page
- each user (query) prefs page.
In addition, there is also the /charset command, which applies to the current view.

I don't think anything more is needed. If you do, please explain clearly what more would be needed; and try to be real convincing if you want to avoid a WONTFIX.