199216 - adding domain.com to whitelist doesn't allow popups from *.domain.com to appear

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[sairuh (rarely reading bugmail)]

adding domain.com to whitelist doesn't allow popups from *.domain.com to appear.
found using 2003.03.25 comm trunk bits.

spoke to shliang about this issue --prolly regressed on 3/21 with the cookies
landing. this blocks bug 195924.

1. go to the Popup Windows pref panel (under Privacy & Security).
2. click "Suppress popups" radiobutton and click the Exceptions button.
3. in the resulting (whitelist) dialog, enter the domain of a site whose popups
you want to view. eg, netscape.com.
4. click OK, OK --to save and dismiss the dialog and prefs window.
5. visit a subdomain of the domain you entered in step 3, eg, home.netscape.com.

expected: the popup window should appear for *.domain.com.

actual results: popups are being blocked when they shouldn't be.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch

Only walk up the domain tree for popups
This is a not-so-nice way to do it, but it needs to be fixed before 1.4a,
without changing the way cookies and images are blocked.

Comment 2

[[e-mail]]

Comment on attachment 118496 [details] [diff] [review]
patch

r=dwitte

Comment 3

[jag (Peter Annema)]

Comment on attachment 118496 [details] [diff] [review]
patch

sr=jag

Comment 4

[[e-mail]]

checked in by timeless @ 1651

Comment 5

[sairuh (rarely reading bugmail)]

looks good using a test build from shliang, which had this patch. thanks so much
for the fast fix!