199278 - Categories in Calendar prefs are not localizable because ASCII is accepted only.

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Michael Wolf]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; wen-DE; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; wen-DE; rv:1.3) Gecko/20030312

I translate Calendar to Sorbian and want to translate the categories in the
Calendar prefs. It's true there is a file categories.properties for that but If
i choose Unicodefor this file, the categories input box of the Calendar
preferences remains empty. Probably this input box doesn't accept Unicode.
Mozilla usually uses escaped Unicode for properties files. I tested UTF8, too,
but the categories input box remains empty. Only if I use ASCII the categories
are displayed.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[matsuba]

User-Agent: Mozilla/5.0 (X11; U; Linux i586; ja-JP; rv:1.4a) Gecko/20030401

Translation in Japanese has also been the same condition.

Comment 2

[Eric Belhaire]

Attachment: patch of toDoDialog.js

It seems that this bug has been already corrected for event Dialog.
Nevertheless the categories in Task Dialog are displayed badly.

Comment 3

[Michael Wolf]

Eric, your patch doesn't help. The categories are not loaded from the file
/locale/categories.properties. If you paste the categories into the categories
input field of the preferences dialog, they are taken over correctly in the new
event and new task dialogs (also with special Unicode characters, in my case
Slavic characters). But, the input field in the preferences remains empty if you
don't fill it by hand. The categories should be loaded from the
categories.properties file of the corresponding locale. On the other hand, it
isn't bad to have the possibility to type the (localized!) categories into the
preferences input field so that categories can be added easier.

Comment 4

[Eric Belhaire]

Attachment: patch of toDoDialog.js, calendar.js, pref/rootCalendarPref.js

Following Michael comments, I completed my patch with the preference loading.
To do this, I chose to modify the GetUnicharPref so it calls the SetUnicharPref
when the preference is not set (This modification has been done for a matter of

coherence with getCharPref). I think that this patch needs a good evaluation
before its inclusion in CVS.

Comment 5

[Eric Belhaire]

Comment on attachment 127151 [details] [diff] [review]
patch of toDoDialog.js,  calendar.js, pref/rootCalendarPref.js

Should I ask for a review by Mostafa or Mike ?
Regards,
Eric

Comment 6

[Mike Potter]

Checked in cvs.

Comment 7

[matsuba]

Verified Fixed by

http://ftp.mozilla.org/pub/mozilla/releases/mozilla1.5a/
mozilla-i686-pc-linux-gnu-ctl-svg-1.5a.tar.gz

Thanks.

Comment 8

[Mostafa Hosseini]

verified.

Comment 9

[Simon Paquet [:sipaq]]

Comment on attachment 127151 [details] [diff] [review]
patch of toDoDialog.js,  calendar.js, pref/rootCalendarPref.js

Patches were checked in

Comment 10

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!