199310 - CompositeDataSourceImpl doesn't release observers in its destructor

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

CompositeDataSourceImpl doesn't release its observers in its destructor. 
Somehow we haven't noticed this leak until it showed up on tinderbox last night.

(The leak currently on tinderbox involves an nsXPCWrappedJS that's an observer,
and which, by staying alive, keeps a bunch of JS objects, including two global
objects, alive.)

The fix is trivial -- convert to nsCOMArray.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Alec Flett]

Comment on attachment 118553 [details] [diff] [review]
patch

nice!
sr=alecf

Comment 3

[Jan Varga [:janv]]

Comment on attachment 118553 [details] [diff] [review]
patch

looks good
r=varga

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This should be pretty low-risk, although there's always the possibility that a
leak fix could expose overreleasing somewhere else and lead to crashes.  It's
also possible that this could fix leaks elsewhere.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 118553 [details] [diff] [review]
patch

Should be safe, good to check out via an alpha release.

/be

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 199269 has been marked as a duplicate of this bug. ***

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2003-03-26 16:01 PST.