199324 - Cygwin's uname returns i1586 on Intel Xeon processors.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Wan-Teh Chang]

We have a Dell Precision 530 workstation with Intel Xeon 2.2GHz CPUs.

Cygwin's "uname -m" command returns "i1586" on that machine.  In
mozilla/nsprpub/configure.in, we have:

1349     case "$target_cpu" in
1350     i?86)
1351             AC_DEFINE(_X86_)
1352         ;;
1353     alpha)
1354             AC_DEFINE(_ALPHA_)
1355             ;;
1356     mips)
1357             AC_DEFINE(_MIPS_)
1358             ;;
1359     *)
1360             AC_DEFINE(_CPU_ARCH_NOT_DEFINED)
1361             ;;
1362     esac

The ? in "i?86" matches exactly one character, so
"i1586" is handled by the default case and the
wrong macro _CPU_ARCH_NOT_DEFINED is defined.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 118563 [details] [diff] [review]
Proposed patch

r=cls with all of the i?86 checks converted to i*86. config.guess uses i*86
everywhere.

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch v2

I converted all i?86 checks to i*86 as cls suggested.
(The other two i?86 checks are used in BeOS and Linux.)

Comment 4

[Wan-Teh Chang]

Fix checked into the tip of NSPR.