Closed Bug 199328 Opened 21 years ago Closed 21 years ago

Bookmarks broken in Phoenix since landing of bug 196756

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firebird0.6

People

(Reporter: seb, Assigned: p_ch)

References

Details

(Keywords: regression)

Attachments

(3 files)

interface changes from mozilla.
151.49 KB, patch
Details | Diff | Splinter Review
new files missing from the diff
3.25 KB, application/octet-stream
Details
port newer changes to nsBookmarksService.cpp back to Phoenix.
8.17 KB, patch
Details | Diff | Splinter Review 
Since the landing of bug 196756 in the trunk, the bookmarks are broken in Phoenix.
They seem to not be loaded at all (don't appear in the Bookmarks menu or in the
bookmarks toolbar, for example).
Keywords: regression
*** Bug 199347 has been marked as a duplicate of this bug. ***
*** Bug 199347 has been marked as a duplicate of this bug. ***
I fixed a few issues in Phoenix, they should load now at least.
It still needs some work, giving to Pierre for now.

Adding a bookmark into a specific folder gives me this exception (the bookmark
is still added though):

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1586" 
data: no]
Dragging the bookmark icon from the address bar to the personal toolbar yields
this exception:

Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIBookmarksService.isBookmarked]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1410" 
data: no]
the sidebar is pretty busted double clicking links doesn't work, although right
clicking and choosing open does. also the spacers have bookmark icons on them
and can be clicked, which produces an error
Jan: do we need to port patches to mozilla to phoenix? esp. interface codes.
-> P2

chanial:
Is this bug should target to Phoenix0.6?
Priority: -- → P2
Noririty: sure. tareting for 0.6
back to Jan. I have no time, atm.
Assignee: chanial → varga
Target Milestone: --- → Phoenix0.6
*** Bug 200260 has been marked as a duplicate of this bug. ***
It also appears that the "Add Bookmark" dialog box doesn't go away when you
click "OK".  You have to hit cancel.
Depends on: 200401
An additional problem has occurred with the 20030402 build. If I make any
changes to the bookmark file, such as moving bookmarks, from within the bookmark
mananger, the changes last until I exit Phoenix. When I restart Phoenix all
changes are lost.
Corwin, your problem is bug 200401
Has this anything to do with bug 200480?
Ok, some bookmarks related Javascript Error Messages:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsIRDFRemoteDataSource.Flush]"
nsresult: "0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)" location: "JS frame ::
chrome://browser/content/bookmarks/addBookmark2.js :: onOK :: line 97" data: no]

Error: uncaught exception: [Exception... "Component returned failure code:
0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS) [nsIRDFRemoteDataSource.Flush]"
nsresult: "0x80520008 (NS_ERROR_FILE_ALREADY_EXISTS)" location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1474" data: no]

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]" nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame ::
chrome://browser/content/bookmarks/bookmarks.js :: anonymous :: line 1586" data: no]

I actually went and checked those lines.. it seems like the
nsIRDFRemoteDataSource.Flush() is broken, since it returns an error code and
writes the bookmarks to %temp% directory instead of overwriting the file.
No longer depends on: 200401
*** Bug 200737 has been marked as a duplicate of this bug. ***
*** Bug 200836 has been marked as a duplicate of this bug. ***
(for future triaging) The drag'n'drop problem with the bookmarks toolbar is bug
199364.
Forget comment #19, bug 199364 was Mozilla-only.

Jan, would it be possible to port the fix from bug 199634 to Phoenix?
With the last few nightly builds (including most recent as of this moment,
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030408
Phoenix/0.5+), I can't import bookmarks at all -- nothing happens, no error, etc.
*** Bug 201503 has been marked as a duplicate of this bug. ***
*** Bug 201503 has been marked as a duplicate of this bug. ***
Bookmarks seem to work fine for me since the 2003-04-09 build.
Nah, drag'n'drop is still broken, and there are still icons on separators in the
bookmarks manager, among others.
i have 11.04.2003 nightly and you can't import your bookmarks - nothing happens.
nothing happens too when you drag urls to the personal toolbal field.
*** Bug 201791 has been marked as a duplicate of this bug. ***
*** Bug 202372 has been marked as a duplicate of this bug. ***
I built 2003-04-02 with perfectly find bookmarks, but 2003-04-17 is definitely still broken.  Shouldn't this be more severe than "major?"
It was broken in the 2003-04-15 build, too.

Bookmarks still won't import from anything, you still can't drag anyyhing 
onto the Bookmarks Toolbar, nor are they sorted on the Bookmarks 
Toolbar as they are in the Bookmarks Manager.  (That sorting problem is 
also occuring in Mozilla 1.3.)
*** Bug 202663 has been marked as a duplicate of this bug. ***
a massive patch (i suppose).

this patch is _NOT_ final, it generates many warnings in JavaScript Console,
removed open in tabs function etc. etc.

this patch does not fix: 
1. exceptions in RDF...
2. personal toolbar DnD issues...

this patch fixes: 
1. new add bookmark dialog
2. new bookmarks management dialog
3. new properties dialog
bug 202477. Closing any browser window causes loooong hang (@
nsBookmarksService::WriteBookmarks).

bug 199872. Bookmarks service doesn't appear to import IE favorites
(does Phoenix has OSX build? :D)
Reassigning to nobody for now, feel free to take it.
Assignee: varga → nobody
back to me.
Chu: I am sorry if you have invested time, I wasn't cc'd to this bug so I was
not aware of your work.
Assignee: nobody → chanial
marking fixed.
I think most of the issues due to the bookmark landing in seamonkey are now
fixed. But a detailed QA is needed here. I still have to sync the
nsBookmarksService.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
chanial: 
have you looked into my nsBookmarksService.cpp patch? I think it contains some
new changes from Mozilla.

and... Why addBookmark2.* is needed in *cough* Firebird? I think the new Mozilla
add bookmark window is quite nice and actually better than the one in Firebird.

At last... it seems that bookmark saving is still broken. (This may be my
problem through)

tried: 
rm -rf .phoenix/
[start phoenix]
phoenix created a default set of bookmarks
restart phoenix
oops... all are gone except web panels...

P.S. what is web panels in fact?
> have you looked into my nsBookmarksService.cpp patch? I think it contains some
new changes from Mozilla.
Yes, I will have a look to it.

> and... Why addBookmark2.* is needed in *cough* Firebird? I think the new
Mozilla add bookmark window is quite nice and actually better than the one in
Firebird.
Because I still do prefer the phoenix dialog even if it must be *a lot* improved
And because addBookmark.js is just horrible.
fwiw, addBookmark.* will be removed.

> At last... it seems that bookmark saving is still broken. (This may be my
problem through)
it works fine here (tm) have you pulled and built phoenix with my checkin already?
if you still encounter the pb, please file a bug

> P.S. what is web panels in fact?
I guess it will be used to display mini web pages in the sidebar (like mozilla)
ok. I also sync'd the bookmarks service
Did this make it into the nightly? Or will that be in the next one? Just
downloaded the latest (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a)
Gecko/20030421 Phoenix/0.5+) and importing bookmarks still has no effect.
Yes, it made the nighly, but there are still glitches (mostly shared by mozilla now)
I opened bug 202879 for the Import failure.

Please open new bugs for the remaining issues since there are a lot of people
cc'd to that bug.
Depends on: 202915
*** Bug 203128 has been marked as a duplicate of this bug. ***
v
Status: RESOLVED → VERIFIED
I still cannot drag a link from a webpage to anywhere (personal toolbar, tab,
etc.)(FB 2003-12-01, winNT), yet this bug was marked fixed back in April.
Reopen? (sorry if this is bugspam)
Check if you have the bookmarks.html in your profile or create a new profile.
That sounds like profile-trouble. Your issue is with 99.9% probability not the
same as this bug. 
Please refer to http://forums.mozillazine.org/viewforum.php?f=38 before going on
bug-hunt in bugzilla. :-)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: