199619 - Cannot create new bookmark folders in "Manage Bookmarks"

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[u63580]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030326
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030326

Using Manage Bookmarks to attempt to create new bookmark folders.  Clicking the
"new folder" button, or selecting "new > folder" from the menu does not create a
new folder.  Nothing happens.

Reproducible: Always

Steps to Reproduce:
1. Manage bookmarks
2. New Folder
Actual Results:  
Nothing

Expected Results:  
New folder created

Running on RedHat Linux 8.0 (kernel 2.4.18)

Comment 1

[Jason Bassford]

Confirming with 3/27-04 build under XP.  (If somebody on MacOS also confirms, we
can make this ALL/ALL.)

However, there is a workaround.

More detailed explanation of what does NOT work:

1. When going into Bookmark Manager, do not ever try creating a new folder while
the "root" folder is highlighted - if you do, you'll never get a new folder
created in that BM session.

2. Do not use the New Folder button from the menu as your *first* method of
creating a new folder.  If you do, same deal as above.

To create a new folder, highlight one of the existing folders (not root) and use
the context menu (right-click).  Once you've done that, you can create as many
new folders as you wish.  Once you've created one via the context menus, the New
Folder button WILL work from that point on.

Comment 2

[u63580]

Glad to hear there is a way around it

Comment 3

[Jason Bassford]

Update: I just installed the 3/28-04 build, and can now use the New Bookmark
button again without having to resort first using the context menu.

However, the first problem in comment 1 remains - if I leave the root folder
highlighted and attempt to create a new folder (using any method) that function
is then horked for the remaining life of the BM session.

Comment 4

[Benjamin Smedberg]

I might be able to get a fix for this today, but don't hold your breath. Jan,
this is yours, I think...

From a debug build, got the following log:

###!!! ASSERTION: illegal value: 'aIndex >= 1', file
../../../../mozilla/rdf/base/src/nsRDFContainer.cpp, line 312
Break: at file ../../../../mozilla/rdf/base/src/nsRDFContainer.cpp, line 312
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIRDFContainer.InsertElementAt]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: anonymous :: line 1614"
 data: no]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.doTransaction]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: anonymous :: line 1348"
 data: no]
************************************************************
An error occurred executing the cmd_bm_newfolder command

Comment 5

[Chris Petersen]

Confirming this issue under 2003-03-28-08 Macho OS X build.

Comment 6

[Kevin Gadd]

Verified Moz 2003032808/WXP SP1

Comment 7

[Samir Gehani]

Nav triage team: nsbeta1+/adt1

Comment 8

[Benjamin Smedberg]

OK, in my impression the UI is broken... and this causes this error.

When you click "Create Folder" a folder is currently created on the same level
as the selected folder. Instead, I believe that it should be created *inside*
the current folder. The error here is caused because we're trying to create a
folder on the same level as NC:BookmarksRoot...bad.

This would involve reworking the logic at 
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarks.js#613
and/or
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarks.js#1333

Comment 9

[Jan Varga [:janv]]

Attachment: patch

Ok, so I disabled all commands for top root container and selected second row
in the view by default.

Comment 10

[Pierre Chanial]

Comment on attachment 118955 [details] [diff] [review]
patch

That's not the proper fix, because one should be able to paste on the bookmarks
root folder and if one selects it, he/she should be able to create a new
folder. Anyway, it's fine with me for 1.4a. Jan, please file a followup bug on
me for 1.4b.

Comment 11

[jag (Peter Annema)]

Comment on attachment 118955 [details] [diff] [review]
patch

sr=jag. Add some comment to the change in bookmarks.js and maybe just comment
out (with a note why) the change in bookmarksTree.xml.

Please find a better fix for 1.4b

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 118955 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.4a.

Comment 13

[Jan Varga [:janv]]

Yes, this is only a quick fix, but as Benjamin pointed out the logic should be
changed. New folders should be created inside the current folder in general, not
only for the root container. Bug 200067 filed.

Comment 14

[Jan Varga [:janv]]

This should be probably fixed in Phoenix too.

Comment 15

[Jason Bassford]

*** Bug 200649 has been marked as a duplicate of this bug. ***

Comment 16

[Chris Petersen]

Verified