Closed
Bug 199683
Opened 21 years ago
Closed 21 years ago
AIX: Preedit string is not highlighted properly
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: pkwarren, Assigned: pkwarren)
References
Details
(Keywords: inputmethod)
Attachments
(1 file, 1 obsolete file)
782 bytes,
patch
|
masaki.katakai
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
On AIX, when characters should be highlighted and underlined, they return a XIMFeedback style of type XIMHighlight | XIMUnderline (0x3). Mozilla currently doesn't support this XIMFeedback style (see code below), so all text which is meant to be shown highlighted and underlined is only underlined. http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsGtkIMEHelper.cpp#298 I have a quick one line patch which fixes this problem.
Assignee | ||
Updated•21 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → mozilla1.4beta
Assignee | ||
Comment 1•21 years ago
|
||
Use style NS_TEXTRANGE_SELECTEDCONVERTEDTEXT for XIMFeedback style XIMHighlight | XIMUnderline.
Assignee | ||
Updated•21 years ago
|
Attachment #118945 -
Flags: superreview?(blizzard)
Attachment #118945 -
Flags: review?(katakai)
Comment 2•21 years ago
|
||
Comment on attachment 118945 [details] [diff] [review] Patch v1 Let's make default to NS_TEXTRANGE_SELECTEDCONVERTEDTEXT. switch (*preeditFeedback++) { case XIMReverse: *pFeedbackAttr = NS_TEXTRANGE_SELECTEDRAWTEXT; break; case XIMUnderline: *pFeedbackAttr = NS_TEXTRANGE_CONVERTEDTEXT; break; default: *pFeedbackAttr = NS_TEXTRANGE_SELECTEDCONVERTEDTEXT; }
Attachment #118945 -
Flags: review?(katakai) → review-
Assignee | ||
Comment 3•21 years ago
|
||
This would make the NS_TEXTRANGE_RAWINPUT style not be used at all - are you sure that this is the correct fix?
Assignee | ||
Comment 4•21 years ago
|
||
Attachment #118945 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #119476 -
Flags: superreview?(blizzard)
Attachment #119476 -
Flags: review?(katakai)
Assignee | ||
Updated•21 years ago
|
Attachment #118945 -
Flags: superreview?(blizzard)
Comment 5•21 years ago
|
||
Comment on attachment 119476 [details] [diff] [review] Patch v2 Yes, most IMEs set the style to Underline and Reverse. gtk+2 also only looks for Underline and Reverse. We can not handle all possible value of the style other than Underline and Reverse. Should be NS_TEXTRANGE_SELECTEDCONVERTEDTEXT, but not NS_TEXTRANGE_RAWINPUT.
Attachment #119476 -
Flags: review?(katakai) → review+
Comment 6•21 years ago
|
||
Comment on attachment 119476 [details] [diff] [review] Patch v2 sr=blizzard
Attachment #119476 -
Flags: superreview?(blizzard) → superreview+
Assignee | ||
Comment 7•21 years ago
|
||
Fixed. Checking in nsGtkIMEHelper.cpp /cvsroot/mozilla/widget/src/gtk/nsGtkIMEHelper.cpp,v <-- nsGtkIMEHelper.cpp new revision: 1.48; previous revision: 1.47 done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•