Closed
Bug 199898
Opened 23 years ago
Closed 22 years ago
Custom header/footer in non-ASCII is displayed as garbage
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kazhik, Assigned: dbaron)
References
Details
(Keywords: intl, Whiteboard: [patch])
Attachments
(1 file, 1 obsolete file)
|
2.88 KB,
patch
|
jshin1987
:
review+
bzbarsky
:
superreview+
chofmann
:
approval1.6+
|
Details | Diff | Splinter Review |
Custom header/footer in non-ASCII is displayed as garbage.
(1) Open "Page Setup" dialog and click "Margins and Header/Footer" tab.
(2) Select "Custom" in one of the listbox of headers/footers.
(3) Enter text in non-ASCII.
(4) Relaunch Mozilla.
(5) See the modified header/footer in "Page Setup" dialog.
Reproduced: 2003032905-trunk/Linux, 2003032908-trunk/Win98
|
||
Comment 2•22 years ago
|
||
This is broken even on Unicode platforms (Win2k/XP, Unix UTF-8 locale)
Keywords: intl
|
Assignee | |
Comment 3•22 years ago
|
||
It's written out correctly in prefs.js. The problem seems to be something with
reading it back in.
|
|
Assignee | |
Comment 4•22 years ago
|
||
This fixes the problem for me, and seems to make sense. I'm a little puzzled
as to why prefs supports an nsISupportsString API for writing prefs, which
makes the writing/reading asymmetric and leads to things like this.
|
|
Assignee | |
Updated•22 years ago
|
Attachment #136885 -
Flags: review?(jshin)
|
|
||
Comment 6•22 years ago
|
||
Comment on attachment 136885 [details] [diff] [review]
patch
great. someday, we may wanna clean up nsString in the file.
r=jshin
Attachment #136885 -
Flags: review?(jshin) → review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #136885 -
Flags: superreview?(bz-vacation)
|
||
Comment 7•22 years ago
|
||
Comment on attachment 136885 [details] [diff] [review]
patch
The pref is set by SetComplexValue, right? So you want to use GetComplexValue
to retrieve it... The fact that prefs stores nsISupportsString complex values
as UTF-8 is an implementation detail of prefs that this code should not rely
on, imo.
Attachment #136885 -
Flags: superreview?(bz-vacation) → superreview-
|
|
Assignee | |
Comment 8•22 years ago
|
||
ok, let's rely on the current storage to convert it to a reasonable mechanism.
Attachment #136885 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #136887 -
Flags: superreview?(bz-vacation)
Attachment #136887 -
Flags: review?(jshin)
|
|
||
Comment 9•22 years ago
|
||
Comment on attachment 136887 [details] [diff] [review]
patch
OK, that works.
Attachment #136887 -
Flags: superreview?(bz-vacation) → superreview+
|
|
||
Comment 10•22 years ago
|
||
Comment on attachment 136887 [details] [diff] [review]
patch
r=jshin
Attachment #136887 -
Flags: review?(jshin) → review+
|
|
Assignee | |
Comment 11•22 years ago
|
||
Comment on attachment 136887 [details] [diff] [review]
patch
simple i18n fix
Attachment #136887 -
Flags: approval1.6?
|
||
Comment 12•22 years ago
|
||
Comment on attachment 136887 [details] [diff] [review]
patch
a=chofmann for 1.6
Attachment #136887 -
Flags: approval1.6? → approval1.6+
|
|
Assignee | |
Comment 13•22 years ago
|
||
Fix checked in to trunk, 2003-12-11 10:42 -0800.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 14•22 years ago
|
||
Fix was verified with 2004012209-trunk on Japanese MS Windows 2000(SP4).
Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•