Closed Bug 199989 Opened 22 years ago Closed 22 years ago

Remove gNoisy code from libeditor.

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: kinmoz, Assigned: timeless)

Details

Attachments

(1 file)

Split off from bug 192569 where sfraser asked: - if (gNoisy) { printf("Editor::Do ----------\n"); } + if (gNoisy) { printf("Editor::DoTransaction ----------\n"); } Can't we clean this up? This code may cause opt builds to link in the static strings. Does anyone use it any more? I never use this stuff, not sure if jfrancis does ... so perhaps it's time to get rid of it.
even if you dont remove it, you should probably #ifdef DEBUG it, this would fix most of warren's build warnings http://tinderbox.mozilla.org/SeaMonkey/warn1049133180.27326.html#warren
Attached patch round 1Splinter Review
i removed unused and buster gNoisys i changed the others to NS_DEBUG/NS_DEBUG_EDITOR
Attachment #122328 - Flags: superreview?(kin)
Attachment #122328 - Flags: review?(brade)
Comment on attachment 122328 [details] [diff] [review] round 1 r=brade Changing sr to alecf since I know Kin is on vacation for 2 weeks.
Attachment #122328 - Flags: superreview?(kin)
Attachment #122328 - Flags: superreview?(alecf)
Attachment #122328 - Flags: review?(brade)
Attachment #122328 - Flags: review+
Comment on attachment 122328 [details] [diff] [review] round 1 nice work! sr=alecf
Attachment #122328 - Flags: superreview?(alecf) → superreview+
In answer to Kin's original question, no, I never used this stuff.
.
Assignee: kin → timeless
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
rs vrfy.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: