Closed
Bug 199989
Opened 22 years ago
Closed 22 years ago
Remove gNoisy code from libeditor.
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
People
(Reporter: kinmoz, Assigned: timeless)
Details
Attachments
(1 file)
24.56 KB,
patch
|
Brade
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
Split off from bug 192569 where sfraser asked:
- if (gNoisy) { printf("Editor::Do ----------\n"); }
+ if (gNoisy) { printf("Editor::DoTransaction ----------\n"); }
Can't we clean this up? This code may cause opt builds to link in the static
strings. Does anyone use it any more?
I never use this stuff, not sure if jfrancis does ... so perhaps it's time to
get rid of it.
even if you dont remove it, you should probably #ifdef DEBUG it, this would fix
most of warren's build warnings
http://tinderbox.mozilla.org/SeaMonkey/warn1049133180.27326.html#warren
i removed unused and buster gNoisys
i changed the others to NS_DEBUG/NS_DEBUG_EDITOR
Attachment #122328 -
Flags: superreview?(kin)
Attachment #122328 -
Flags: review?(brade)
Comment 3•22 years ago
|
||
Comment on attachment 122328 [details] [diff] [review]
round 1
r=brade
Changing sr to alecf since I know Kin is on vacation for 2 weeks.
Attachment #122328 -
Flags: superreview?(kin)
Attachment #122328 -
Flags: superreview?(alecf)
Attachment #122328 -
Flags: review?(brade)
Attachment #122328 -
Flags: review+
Comment 4•22 years ago
|
||
Comment on attachment 122328 [details] [diff] [review]
round 1
nice work! sr=alecf
Attachment #122328 -
Flags: superreview?(alecf) → superreview+
Comment 5•22 years ago
|
||
In answer to Kin's original question, no, I never used this stuff.
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•