200009 - classic privacy dialog icon is a modern picture

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[timeless]

actual results, picture looks like:
http://lxr.mozilla.org/seamonkey/source/extensions/cookie/resources/skin/modern/status-cookie.gif

expected results, a picture of classic with that widget.

Comment 1

[timeless]

Attachment: newclassic

Comment 2

[timeless]

Comment on attachment 118989 [details]
newclassic

whoops. i suppose i should use classic if i want to do this right :-|

Comment 3

[[e-mail]]

doesn't harishd own p3p? ;)

Comment 4

[Andreas Kunz]

Attachment: Classic status-cookie.gif

This should replace the modern gif currently residing at
http://lxr.mozilla.org/seamonkey/source/extensions/cookie/resources/skin/classic/status-cookie.gif


I'll request review as soon as I tested it (classic status bar is taller and
the icon panels are wider, so I want to make sure this larger gif does not
break anything).

Comment 5

[Andreas Kunz]

Comment on attachment 144278 [details]
Classic status-cookie.gif

Ok, I tested it; works fine.
Requesting r= from mvl (or should I ask dwitte?).

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 144278 [details]
Classic status-cookie.gif

This image has a resizer widget, while the modern doesn't have it. Was that
widget added after the image was created?
Not that it really matters for this bug...
I'm not sure who should review this, an ui person or an p3p person. But i'm not
either.... (that said, it looks fine to me :) )

Comment 7

[Andreas Kunz]

Comment on attachment 144278 [details]
Classic status-cookie.gif

Well, I just took a screenshot of the lower right corner. The old modern
screenshot also looks like it covers all of that corner. Maybe at that time
there was no resize widget on modern yet.

This graphic's aim seems to be to show where that "eye" icon is, which seems a
bit odd since I think the only way to show that dialog is to click on that eye.
But anyway, I think my graphic does what it is supposed to.

Changing review request to dwitte.

Comment 8

[[e-mail]]

Comment on attachment 144278 [details]
Classic status-cookie.gif

i'm not really the one for this either...

kicking the soccerball to mconnor.

Comment 9

[Andreas Kunz]

Comment on attachment 144278 [details]
Classic status-cookie.gif

Requesting r= from alecf.

Comment 10

[Alec Flett]

Comment on attachment 144278 [details]
Classic status-cookie.gif

sr=alecf

Comment 11

[Andreas Kunz]

Comment on attachment 144278 [details]
Classic status-cookie.gif

Nice to have in 1.7...

Comment 12

[chris hofmann]

Comment on attachment 144278 [details]
Classic status-cookie.gif

a=chofmann for 1.7

Comment 13

[[e-mail]]

Checking in status-cookie.gif;
/cvsroot/mozilla/extensions/cookie/resources/skin/classic/status-cookie.gif,v 
<--  status-cookie.gif
new revision: 1.4; previous revision: 1.3
done

Comment 14

[benc]

yummy. gimmie cookie.