200139 - htmlparser has way too many tables

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Alec Flett]

nsHTMLEntities.cpp defines way too many tables, and allocates a whole bunch of
them for no good reason. Attached is a fix, which includes lots of const-ness
which sfraser will be happy about.

Comment 1

[Alec Flett]

Attachment: clean up nsAVLTree, and entities

this cleans up a lot of junk.

Comment 2

[Alec Flett]

Comment on attachment 119079 [details] [diff] [review]
clean up nsAVLTree, and entities

simon/harish, can I get some reviews? this is really an easy one.

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 119079 [details] [diff] [review]
clean up nsAVLTree, and entities

Bonus points if you rename all the 'comparitor' to 'comparator'.

Comment 4

[harishd]

Comment on attachment 119079 [details] [diff] [review]
clean up nsAVLTree, and entities

r=harishd

Comment 5

[Alec Flett]

that was easy. fixed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Note that EntityNode constructor/destructor stuff gets counted (via
MOZ_COUNT_CTOR/DTOR), and since the static array is never eliminated, this patch
makes us look like we're leaking tons of EntityNode objects....

Comment 7

[Alec Flett]

just to follow up, when the patch was re-landed, I removed all the
COUNT_CTOR/COUNT_DTOR stuff.. the only EntityNodes that get created beyond the
static const list are on the stack, when doing a search of the nsAVLTrees

(and yeah yeah, I'm working on getting rid of the nsAVLTrees)