Closed
Bug 200144
Opened 23 years ago
Closed 22 years ago
Keep OS/2 from going down MSVC paths in JS
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: khanson)
Details
Attachments
(2 files)
|
3.47 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
|
1.99 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Offshoot from bug 74999. Currently, OS/2 enables many code paths which were
originally put in as workarounds for MS Visual C++ bugs. We should not go down
those paths on OS/2 if not necessary. See the patch in bug 74999 for some of
the relevant lines of code.
We will wait to handle this until after the move from Visual Age to GCC is
complete on OS/2.
|
||
Comment 1•23 years ago
|
||
Reassigning, and cc'ing developers from bug 74999 -
Assignee: rogerl → khanson
|
||
Comment 2•22 years ago
|
||
OK, here's what the patch would look like.
Any idea how to test this stuff?
|
|
||
Comment 3•22 years ago
|
||
Might as well fix XSLT while we are here.
We have verified that OS/2 doesn't have these issues
|
|
||
Updated•22 years ago
|
Attachment #135941 -
Flags: review?(brendan)
|
|
||
Updated•22 years ago
|
Attachment #135951 -
Flags: review?(bugmail)
|
|
||
Comment 4•22 years ago
|
||
Comment on attachment 135941 [details] [diff] [review]
Here's the patch
Sure, looks good to me.
/be
Attachment #135941 -
Flags: review?(brendan) → review+
Attachment #135951 -
Flags: review?(bugmail) → review+
|
|
||
Comment 5•22 years ago
|
||
Fixes checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•22 years ago
|
||
For anybody who would have the same reaction as me reading the patch for this
bug, the spin off to also correct MinGW builds is bug 226276.
|
||
Updated•20 years ago
|
Flags: testcase-
You need to log in
before you can comment on or make changes to this bug.
Description
•