200160 - OS X: droplists in chrome don't get focus in aqua/classic theme

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[sairuh (rarely reading bugmail)]

spun off from bug 123617. in Mac OS X using the aqua/classic theme, tabbing
still does not focus droplists (aka, menulists, selection lists) in chrome. it
doesn't matter what the accessibility.tabfocus pref is set to, either.

to observe:

1. open Preferences and go to a panel which has a droplist. the following would
suffice:

Navigator - Languages
Mail & Newsgroups - Message Display
Mail & Newsgroups - Return Receipts
Advanced - Mouse Wheel

2. start hitting the tab key...

results: droplists in chrome are skipped in the tabbing cycle.

Comment 1

[Paul Wyskoczka]

Nav triage team: nsbeta1+/adt3

Comment 2

[shliang]

Attachment: patch

Comment 3

[jag (Peter Annema)]

Note that right now that pref only affects HTML. To make XUL follow similar
logic we'll have to add some code to nsEventStateManager::GetNextTabbableContent.

With this patch, we'll make it so we always tab into menulists in the Mac
classic skin. Better than what we had, but moving us away from what the OS does
(in the default configuration).

Comment 4

[jag (Peter Annema)]

Comment on attachment 123022 [details] [diff] [review]
patch

r+sr=jag

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 123022 [details] [diff] [review]
patch

looking at the other menulist.css files, this is the only one that was doing
moz-user-focus.

were the others fix, but this one forgotten?

why did hewitt add it?	(for a bug?)

from cvs blame, this was added here:

XUL/theme simplification changes - removing unnecessary boxes and re-writing
large portions of the themes to use new -moz-border-colors and
-moz-image-region css features. Also cleans up the classic skin quite a bit for
both mac and win. Fixes bugs 113024, 113043, 113585, 113586, 115943, 113643,
114475, 99787, 110214, 113977, 113966, 114802, 64894, 90724, 103173, 103199,
103298, 110442, 111472, 111989, 113027, 113041, 109180, 109204, 81581, 81903,
103324, 110108, 114540, and probably more I forgot to mention. r=ben, sr=hyatt

given where we are in 1.4 final, double check those bugs, to see if it was
added for a specific reason or not.

let me know, and then I can give a=sspitzer

or, if you (and the the reviewer) think this is overkill, and this is a simple
fix, well tested, with no chances for regressions, let me know.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 123022 [details] [diff] [review]
patch

shuehan tells me:

this was spun off from 123617, where the -moz-user-focus line had gotten
removed from some of the other widgets, just didn't do menulists.

and, she said she checked with bryner.

so a=sspitzer

Comment 7

[shliang]

checked in

Comment 8

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.05.19.08 comm trunk on mac os x 10.2.6. xul droplists are
now part of the tabbing cycle. the only remaining "hitch" is that the focus ring
is barely perceptible --it's there, but it appears as a subtle highlight at the
corners of the droplist's "button" image.