200359 - Importing and exporting bookmarks are broken

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Tom Ligda]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030402 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030402

Exported bookmarks from 3/31/03 daily build and imported them in the 4/2/03
build in the Bookmark Manager. The action completes without any error messages
but the bookmarks never appear in the list. This worked fine in the 3/31/03 build.

Reproducible: Always

Steps to Reproduce:
1. Create bookmarks in the 3/31/03 build.
2. Export bookmarks from the Bookmark Manager.
3. Install the 4/2/03 build.
4. Import the bookmarks that were exported in step 2 from the Bookmark Manager.

Actual Results:  
The bookmarks don't show up and there are no error messages.

Expected Results:  
The bookmarks should show up in the Bookmark Manager.

This was using the default theme, originally found using Phoenix but verified in
Mozilla.

Comment 1

[Tim H.]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030402 Phoenix/0.5

Also receiving this error on the nightly build.  Build from 4/1/02 works fine as
I just installed it on another machine last night.  Export does not seem to work
either and no error message is given.

Comment 2

[nucleos]

Same thing with a bookmarks file created the 03.29.2003.
Impossible to import that file with a 04.03.2003 Mozilla build.

(system running on WinXP)

I've noticed also that nothing happens when trying to create a new bookmarks file.

No error messages, in the both situations.

Comment 3

[Jason Bassford]

*** Bug 200781 has been marked as a duplicate of this bug. ***

Comment 4

[Jason Bassford]

Confirming due to number of comments from different sources.

Comment 5

[Jason Bassford]

Really confirming...

Comment 6

[Jamie R. Rytlewski]

I am having the exact same problem.  I was just about to make the switch to
Mozilla full time and I cannot import my IE bookmarks.  I am using Windows XP
and Mozilla 1.4a that was downloaded on the 2nd of April.

Comment 7

[Jason Bassford]

Importing IE bookmarks is a separate issue.

Comment 8

[noririty]

*** Bug 200835 has been marked as a duplicate of this bug. ***

Comment 9

[Sébastien Delahaye]

*** Bug 201722 has been marked as a duplicate of this bug. ***

Comment 10

[Mr.Freeze]

Sorry for duplicate bug #201722
When it comes to importing IE favorites, there are other solutions too:
http://bookmarkbridge.sourceforge.net/

When is its integration scheduled?

Comment 11

[Jason Bassford]

*** Bug 201926 has been marked as a duplicate of this bug. ***

Comment 12

[Pierre Chanial]

taking

Comment 13

[Pierre Chanial]

updating summary, patch will follow

Comment 14

[Pierre Chanial]

Attachment: patch v1.0

this bug has regressed after the nsIfile conversion.
The problem is that we sent 'file:///home/blabla' filepaths to NS_NewLocaleFile

Strangely enough, it seems like nsFileSpec do trim 'file://' and
NS_NewLocaleFile doesn't. 
Maybe it should?

In the patch, I trim the file path in the callers (bookmarks.js)
I also consolidated and cleaned the export and import methods in the bookmarks
service.

Comment 15

[Pierre Chanial]

Ah, I forgot to mention that the diff are against the phoenix tree. there's no
difference with mozilla's one in that area.

Comment 16

[Pierre Chanial]

Attachment: patch v2.0

aheum. forget my last comment. 
the file picker output just needed to be converted also to nsIFile.
like the previous patch, everything in nsBookmarksService is cleanup.

Comment 17

[Pierre Chanial]

Attachment: patch v2.0

I attached a random file. here is the proper one.

Comment 18

[Benjamin Smedberg]

Comment on attachment 121380 [details] [diff] [review]
patch v2.0

looks good, r=bsmedberg

Comment 19

[aynilove [So, Jae-yoon]]

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.4b) Gecko/20030419
Import Netscape 4.8 bookmark failed without any message.

Comment 20

[Alec Flett]

Comment on attachment 121380 [details] [diff] [review]
patch v2.0

sr=alecf

Comment 21

[Pierre Chanial]

Comment on attachment 121380 [details] [diff] [review]
patch v2.0

request approval for 1.4b.
risk is very low, the two liner patch only affect the broken import and export
commands and the rest is clean up.
(patch already committed in phoenix)

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 121380 [details] [diff] [review]
patch v2.0

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 23

[Pierre Chanial]

marking fixed

Comment 24

[Chris Petersen]

Verified in the 2003-04-28-03 Macho and 2003-04-28-04 Win32 build.