200437 - fix assertion in GetCookie()

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[[e-mail]]

this one was introduced ages ago, at some point after the cookie string rewrite.

CharAt is asserting if you try to read off the end of the string, so we just
need to shift that call to after the length check. it looked ugly so i
refactored into a helper function, consistent with the parser stuff, to look nicer.

thanks to mvl for spotting these assertions :)

Comment 1

[[e-mail]]

Attachment: fix

Comment 2

[Darin Fisher]

Comment on attachment 119268 [details] [diff] [review]
fix

sr=darin

Comment 3

[[e-mail]]

Attachment: fix 2

now with updated comment, per mvl's request.

Comment 4

[[e-mail]]

Comment on attachment 119274 [details] [diff] [review]
fix 2

carrying over r/sr.

Comment 5

[[e-mail]]

fixed-on-trunk @ 0117 by Neil. thanks!

Comment 6

[benc]

If someone has a simple case w/ some output that shows an assertion happening
(then going away post-fix), if you could paste that in here and VERIFIED/FIXED,
that would be great.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Without that patch, I see the assertions while running dwitte's TestCookie.cpp.

###!!! ASSERTION: |CharAt| out-of-range: 'i<Length()', file
../../dist/include/string/nsASingleFragmentString.h, line 197
Break: at file ../../dist/include/string/nsASingleFragmentString.h, line 197

With a current cvs trunk build, I don't see the assertions while running the
same file. (nothing to paste here :) )