20058 - Remove gray area from navigation toolbar

Status: VERIFIED FIXED

(SeaMonkey :: General, enhancement, P3)

Description

[Philip I. Long]

Forward -- I like the new look (since M9) a lot better than before.

The toolbar seems to be shorter than the navigaiton buttons (<-),
(->), (^), (X) so that the bottom few pixels of the buttons overrun the
blue-black field of the toolbar.  I'd suggest either moving the buttons
up (preferably), or making the toolbar wider.  This applies to both win32
(2000022916) and linux (2000022913).

Comment 1

[Claudius Gayle]

this bug is going to be resolved as a duplicate of another bug which is
probably resolved/invalid. I have not already done so because i can't
remember the bug number and the reporter deserves to know the reasoning
behind why this I believe, as designed. I'm reassigning to german in hopes
that he'll remember the bug where he expalined all this.

Comment 2

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 3

[Matthew T (active 1999-2002)]

I've spent some time searching and I can't find the bug this is apparently a dup 
of, either.

The URL I've given is a message from n.p.m.ui which contains a patch to fix this 
bug (it looks like a bug, it feels like a bug, therefore ... etc), from Florian 
<[e-mail]>. It may need some tidying/fixing to work with the latest 
builds, but if so, Florian may be willing to make the necessary changes (so I'm 
CCing Florian here).

Opinions about the revised toolbar in the n.p.m.ui newsgroup were, according to 
a count I've just made (and ignoring multiple posts from the same sender), 7 in 
favour, none against.

Comment 4

[Matthew T (active 1999-2002)]

*** Bug 28384 has been marked as a duplicate of this bug. ***

Comment 5

[Matthew T (active 1999-2002)]

Updating milestone, dependency, and assignee, based on bug 28384 which was a dup 
of this bug.

[e-mail] also said:
>
> Some more changes are required to simplify and make toolbars be the only
> elements inside a toolbox (those changes have also been submitted earlier to 
> Ben) with all toolbars having a throbber area to the right.
>
> some pseudo XUL that hilites the plan:
> <toolbox>
>   <bookmarksbar>
>     <bookmarkbuttons...>
>     <bookmarkthrobber>
>   </bookmarksbar>
>   <navbar>
>     <navbarbuttons...>
>     <urlbar>
>     <search>
>     <navbarthrobber>
>   </navbar>
> <toolbox>

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

will fix this when resolving skinnability issues

Comment 7

[Claudius Gayle]

as i rememeber it (from the bug I still can't find) the overhanging buttons were on purpose. what's supposed to be gone is the 
empty gray space below them. That way the buttons actually leak over into the content portion for a very blended look.

Comment 8

[Matthew T (active 1999-2002)]

That's probably true, but a couple of weeks ago German suddenly realized that 
that would no longer work once Mozilla gained the ability to rearrange toolbars: 
`the grey area would be wedged between toolbars if users wnat to move the 
bookmarks bar to the bottom position'. (And advanced users Most Certainly Will 
want to do exactly that, as soon as they first start Mozilla.)

That's what prompted German to write up bug 28384, which was a dup of this bug.
`I recommend', quoth he, `a design where the full toolbar is using the striped 
blue background spanning its whole height.' And murmurs of relief were heard 
throughout the land.

Comment 9

[don]

Move to M16 for now ...

Comment 10

[locka]

*** Bug 34676 has been marked as a duplicate of this bug. ***

Comment 11

[Peter Trudelle]

Mass-adding beta2 keyword to all skins bugs.

Comment 12

[Matthew T (active 1999-2002)]

*** Bug 30411 has been marked as a duplicate of this bug. ***

Comment 13

[Matthew T (active 1999-2002)]

Resummarizing to help prevent further dups, and removing patch keyword since the 
patch is obviously not going to be used.

Comment 14

[Matthew T (active 1999-2002)]

*** Bug 30545 has been marked as a duplicate of this bug. ***

Comment 15

[Matthew T (active 1999-2002)]

*** Bug 22999 has been marked as a duplicate of this bug. ***

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

fix checked in. 

Comment 17

[Claudius Gayle]

VERIFIED Fixed with 2000050112 builds