200659 - Remove goto's from mimecms.cpp

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[David G King]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030403
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030403

As a matter of good programming style, and to avoid tree redness, mimecms should
not use goto's.

Reproducible: Always

Steps to Reproduce:
1. Change code without realising it has goto's
2. Watch tree go red

Comment 1

[David G King]

Taking.

Comment 2

[David G King]

Attachment: First, basic patch.

Well, it should work, now to see what gcc says about it.

Comment 3

[David G King]

Comment on attachment 127845 [details] [diff] [review]
First, basic patch.

OK, so I forgot all about this bug. Patch is still valid....

Asking for a "r".

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 127845 [details] [diff] [review]
First, basic patch.

r=kaie

If you want, feel free to change 
  match = PR_FALSE;
  return match;
to
  return PR_FALSE;
in both places.

Comment 5

[David G King]

Attachment: Includes suggestions from Kai, and some whitespace weirdness

Comment 6

[David G King]

Comment on attachment 135081 [details] [diff] [review]
Includes suggestions from Kai, and some whitespace weirdness

Carrying over Kai's Review +. Seeking SR, although I don't think I have Seth's
correct eMail address.

Comment 7

[David G King]

Comment on attachment 135081 [details] [diff] [review]
Includes suggestions from Kai, and some whitespace weirdness

Seth is obviously very busy, so I'm asking mscott for a SR.

Comment 8

[David G King]

Attachment: Updated to match current tree

Comment 9

[David G King]

Comment on attachment 138195 [details] [diff] [review]
Updated to match current tree

Carrying over R from kaie

Comment 10

[David G King]

Comment on attachment 138195 [details] [diff] [review]
Updated to match current tree

Asking for SR, and if Seth could check it in as well?

Comment 11

[Boris Zbarsky [:bzbarsky]]

David, Seth is not really doing reviews that I know of.. mscott is in fact your
best bet.

Comment 12

[David G King]

Comment on attachment 138195 [details] [diff] [review]
Updated to match current tree

bz: Thanks for the pointer

Comment 13

[David G King]

Thanks, can someone check this in for me as I have no checkin rights.

Comment 14

[David G King]

Thanks to bz for checking this in for me.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR:

1.22	bzbarsky%mit.edu	2004-05-04 17:55	 	Remove goto's from mimecms.cpp. Bug
200659, patch by David G King
<[e-mail]>, r=kaie, sr=mscott