200662 - GetCurrentProcessDirectory can fail

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Conrad Carlen (not reading bugmail)]

Here: http://lxr.mozilla.org/seamonkey/source/xpcom/io/nsDirectoryService.cpp#205,
it's possible for bundleURL to be a compound URL, that is, one which has a base
+ a string portion. That's a problem because CFURLCopyFileSystemPath() will not
return the absolute path for such a URL, only the string portion. The doc in the
header file for CFURLCopyFileSystemPath says: "The URL is not resolved against
its base before computing the path." Patch coming up which instead uses
CFURLGetFileSystemRepresentation() with which you can tell it to resolve the
full path.

BTW, I encountered this only when playing with the CHBrowserView framework. When
called from application code, it's fine. When called from code within the
framework, the form of the URL we get back from the bundle is different.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Comment 2

[Conrad Carlen (not reading bugmail)]

Comment on attachment 119443 [details] [diff] [review]
patch

Simon, if you give it an r=/sr=, that should be enough. I'm not sure who else
these days knows much about this stuff.

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 119443 [details] [diff] [review]
patch

Please add a comment in the  code to say why you have to do it that way.
r/sr=sfraser

Comment 4

[Conrad Carlen (not reading bugmail)]

Checked in.