Closed Bug 20072 Opened 25 years ago Closed 25 years ago

On redirected channel should get the redirect url

Categories

(Core :: Networking, defect, P3)

x86
Windows NT
defect

Tracking

()

VERIFIED DUPLICATE of bug 27048

People

(Reporter: radha, Assigned: gagan)

References

Details

(Whiteboard: [PDT+] 2/28/00)

This  bug is, new incarnation of
http://bugzilla.mozilla.org/show_bug.cgi?id=10647. Descriptions from that bug
include:

------- Additional Comments From andreas.otte@primus-online.de  09/12/99 07:50
-------
This is definitly not an URL-parsing problem. As I see it, the problem is, that
when a redirect happens there is made a new channel which replaces the old one.
The URL of this new channel has the missing /, all is fine, but whoever is
making the request is not informed of this change. So OnEndDocumentLoad is
called with the old channel and the URL of that Channel is still the
unredirected and that url is displayed in the urlbar. I think there are at least
two options:

1. Update the old channels URL ... don't like it
2. Implement the nsIHttpEventSink interface for the caller (if possible) and
change the current channel with OnRedirect


------- Additional Comments From andreas.otte@primus-online.de  11/23/99 11:56
-------
The problem here is that there is a new channel created during redirection, but
that new channel (with the new URI) is not propagated to whoever is making the
request. As a result the channel used on the webshell (or whoever is calling)
does not contain the right url and other functions that use it fail afterwards.
This is not only an issue about updating the urlbar or not.
I still think the only option is to implement EventSink or uriLoader or whatever
for nsWebShell and let the channel (and the URI of the Webshell itself) be
updated by OnRedirect.


This depends on the uriloader work.
Status: NEW → ASSIGNED
Depends on: 14928
Target Milestone: M13
Assignee: radha → warren
Status: ASSIGNED → NEW
Reassigniing to warren. This is probably a dup of something he has.
Assignee: warren → gagan
Component: Browser-General → Networking
Summary: On redirected urls, the channel passed up to necko listeners/observers should have the new redirected url → On redirected channel should get the redirect url
-> gagan
QA Contact: leger → tever
re-assigning QA contact to myself
cc'ing warren and rpotts.
Target Milestone: M13 → M14
Keywords: beta1
pdt - what is the user impact, are redirects not working?
Adding [NEED INFO] to Status Summary.
Whiteboard: [NEED INFO]
see latest comments on bug 10647 for possible impact
Whiteboard: [NEED INFO] → [PDT+]
need info from rpotts on whether this is a dependent on bug 27048 or we need to 
hack a work around...? If we do the 27048 (which IMHO is the right way) then 
this is taken care of in the OnRedirect call of the HTTPEventSink. If not we 
need to figure out a clean way to take the redirected URI in the OnStopRequest.
Depends on: 27048
Whiteboard: [PDT+] → [PDT+] no estimate
I also think implementing nsIHTTPEventSink for the webshell is the right thing
to do. Another option would be the cheap fix I proposed in bug 10647, but I
don't like that at all.
Blocks: 28748
Blocks: 28728
gagan/warren, what's this latest on this one?
Whiteboard: [PDT+] no estimate → [PDT+] 2/28/00
blocking only on 27048
Status: NEW → ASSIGNED
removing myself from the cc list
I am going to mark this as dup for the HTTPEventSink since that one will fix 
this too. 

*** This bug has been marked as a duplicate of 27048 ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
verifying dupe of 27048
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.