2009019 - Support actions in Github based Gecko Decision tasks

Status: RESOLVED FIXED

(Release Engineering :: Firefox-CI Administration, enhancement)

Description

[Andrew Halberstadt [:ahal]]

The Git version of the Gecko decision task doesn't support actions yet.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-releng/fxci-config] Bug 2009019 - Create in_tree_action hooks for the enterprise trust do… (#727)

Comment 2

[BMO Github Automation]

Authored by https://github.com/ahal
https://github.com/mozilla-releng/fxci-config/commit/33b60e90729e26f0862cbb1d94ff8ec855dfc163
[main] Bug 2009019 - Create in_tree_action hooks for the enterprise trust domain

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: GitHub Pull Request

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: GitHub Pull Request

Comment 5

[Andrew Halberstadt [:ahal]]

Actions are now working, though we still need to create a group to grant a scope so enterprise devs can trigger them.

Comment 6

[Andrew Halberstadt [:ahal]]

Actually, I still need to port the patches over to firefox-main.. I'll keep using this bug for that.

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2009019 - Structure .taskcluster.yml to be a single task, r?#taskgraph-reviewers

In order to support actions, the .taskcluster.yml must be structured
as a single task. This is because when fxci-config generates the
hooks, it uses tcyml.tasks[0] as the hook task definition.

When we were defining separate tasks for hg and git, then the git
implementation of the Decision task was being discarded.

This refactors the .tc.yml a bit such that there is only a single
top-level task. This is a bit cleaner anyway as it guarantees it will
always be one or the other, with no possibility of accidentally
scheduling two Decision tasks.

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2009019 - Remove assertion that we're using hgmo in actions logic, r?#taskgraph-reviewers

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2009019 - Add additional context needed to render action tasks, r?#taskgraph-reviewers

This adds 'branch' and 'base_branch' to the push context, as well as
starts passing certain params via the 'parameters' context (just
'repository_type' for now).

Comment 10

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2009019 - Support Taskcluster actions in Github based Decision tasks, r?#taskgraph-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f5c7979bb036
https://hg.mozilla.org/integration/autoland/rev/1baedd9c1f40
Structure .taskcluster.yml to be a single task, r=taskgraph-reviewers,releng-reviewers,bhearsum
https://github.com/mozilla-firefox/firefox/commit/47782ef28abc
https://hg.mozilla.org/integration/autoland/rev/96a09ef78e9d
Remove assertion that we're using hgmo in actions logic, r=taskgraph-reviewers,releng-reviewers,bhearsum
https://github.com/mozilla-firefox/firefox/commit/c51574939a44
https://hg.mozilla.org/integration/autoland/rev/598979668139
Add additional context needed to render action tasks, r=taskgraph-reviewers,releng-reviewers,bhearsum
https://github.com/mozilla-firefox/firefox/commit/65a2caf33312
https://hg.mozilla.org/integration/autoland/rev/76ae3ec46d55
Support Taskcluster actions in Github based Decision tasks, r=taskgraph-reviewers,releng-reviewers,jcristau

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1baedd9c1f40
https://hg.mozilla.org/mozilla-central/rev/96a09ef78e9d
https://hg.mozilla.org/mozilla-central/rev/598979668139
https://hg.mozilla.org/mozilla-central/rev/76ae3ec46d55

Comment 13

[Andrew Halberstadt [:ahal]]

Re-opening for a follow-up fix for pr-actions

Comment 14

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2009019 - Assume proper role for pr-actions in Github based Decision tasks, r?jcristau!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1e76783b081
https://hg.mozilla.org/integration/autoland/rev/ab9c842f982d
Assume proper role for pr-actions in Github based Decision tasks, r=releng-reviewers,bhearsum

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7700fb28c1f1
https://hg.mozilla.org/integration/autoland/rev/52b4d588b8bd
Revert "Bug 2009019 - Assume proper role for pr-actions in Github based Decision tasks, r=releng-reviewers,bhearsum" for causing CoT verification failures

Comment 17

[Sandor Molnar[:smolnar]]

Backed out for causing CoT verification failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/52b4d588b8bdb542c9e488953e669bc7d6ed9dcf

Push with failures

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/099f0a496a1f
https://hg.mozilla.org/integration/autoland/rev/6128fe737002
Assume proper role for pr-actions in Github based Decision tasks, r=releng-reviewers,bhearsum

Comment 19

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6128fe737002