200971 - nsConnectionEntry is leaked

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Brian Ryner (not reading)]

From a valgrind run I did:

==16819== 56 bytes in 2 blocks are definitely lost in loss record 53 of 155
==16819==    at 0x40044720: __builtin_new (vg_clientfuncs.c:125)
==16819==    by 0x44ECF194:
nsHttpConnectionMgr::OnMsgNewTransaction(nsHttpTransaction *)
(/builds/mozilla/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp:652)
==16819==    by 0x44ECFAF0: nsHttpConnectionMgr::OnSocketEvent(unsigned int,
unsigned int, void *)
(/builds/mozilla/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp:819)
==16819==    by 0x44E8DA01: nsSocketTransportService::ServiceEventQ(void)
(/builds/mozilla/netwerk/base/src/nsSocketTransportService2.cpp:302)
==16819==    by 0x44E8E8F5: nsSocketTransportService::Run(void)
(/builds/mozilla/netwerk/base/src/nsSocketTransportService2.cpp:606)
==16819==    by 0x41CA31ED: nsThread::Main(void *)
(/builds/mozilla/xpcom/threads/nsThread.cpp:118)
==16819==    by 0x4032DF6A: _pt_root
(/builds/mozilla/nsprpub/pr/src/pthreads/ptthread.c:214)
==16819==    by 0x40344417: thread_wrapper (vg_libpthread.c:636)
==16819==    by 0x40049470: do__apply_in_new_thread_bogusRA (vg_scheduler.c:2030)

This is also backed up by refcount logging which shows 3 leaked nsVoidArrays
(nsConnectionEntry contains 3 voidarrays).

It looks like we should be cleaning these up at shutdown; I'm not sure why that
isn't happening in this ase.

Comment 1

[Brian Ryner (not reading)]

Attachment: fix attempt

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 119634 [details] [diff] [review]
fix attempt

r= with sr=darin.

Comment 3

[Darin Fisher]

Comment on attachment 119634 [details] [diff] [review]
fix attempt

sr=darin (thanks bryner!!)

Comment 4

[Darin Fisher]

-> bryner

Comment 5

[Darin Fisher]

Checking in nsHttpConnectionMgr.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpConnectionMgr.cpp,v  <-- 
nsHttpConnectionMgr.cpp
new revision: 1.6; previous revision: 1.5