201013 - Move bookmarks transaction manager to bookmarks service

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Jan Varga [:janv]]

As Pierre already pointed out, this is the real fix for all the bugs related to
uninitialized transaction manager in 2nd window.
I'll add dependencies later.
Patch coming ...

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Andreas Kunz]

I think it's not exactly the 2nd window, but every window opened after e.g.
doing d'n'd in the PT (or other bookmarks things). 
But you probably just wanted to make the description shorter, so as long as the
patch helps, go for it! :-)

Comment 3

[Jan Varga [:janv]]

Exactly, I'm sure Pierre knows what I'm talking about ;)

Comment 4

[Pierre Chanial]

Comment on attachment 119670 [details] [diff] [review]
patch

Thanks for the patch, Jan.
Maybe the bookmark transaction manager should be lazily initialized in
GetBookmarkManager?
It's up to you

Comment 5

[jag (Peter Annema)]

Comment on attachment 119670 [details] [diff] [review]
patch

I don't think you need an NS_IF_ADDREF there, just NS_ADDREF should do. If
nsBookmarksService::Init failed (which it will if mTransactionManager is
nsnull) you shouldn't have access to the service, so you wouldn't be able to
addref a null there.

sr=jag

Comment 6

[[e-mail]]

Quick question: (when) is the transaction manager released?

Comment 7

[Jan Varga [:janv]]

checked in

Comment 8

[Jan Varga [:janv]]

thanks for reviews, btw

Comment 9

[Chris Petersen]

Verified per last comments.