Closed Bug 201130 Opened 22 years ago Closed 22 years ago

nsWindow::ApplyTransparencyBitmap() tries to return a value

Categories

(Core Graveyard :: Embedding: GTK Widget, defect)

Sun
SunOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozbugs, Assigned: blizzard)

Details

User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4a) Gecko/20030330 Build Identifier: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4a) Gecko/20030330 In widget/src/gtk/nsWindow.cpp, nsWindow::ApplyTransparencyBitmap() tries to return NS_ERROR_FAILURE, but is declared as null. This upsets my picky compiler. I changed it to NS_IMETHODIMP, and NS_IMETHOD in the header, which seems to make everything happy. Reproducible: Always Steps to Reproduce: 1. 2. 3.
From http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/widget/src/gtk/nsWindow.cpp 1.400 bryner%netscape.com Apr 7 01:04 don't return a value from a |void| function. fixing ports bustage.
Status: UNCONFIRMED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.