Closed Bug 201158 Opened 22 years ago Closed 8 years ago

[gtk2]can not resize plugin properly

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: iamawalrus, Assigned: iamawalrus)

References

Details

Attachments

(2 files, 1 obsolete file)

1. install plugin for pdf from acrobat 2. lanch mozilla and do not resize it to maxim size. 3. open a link of pdf file, for example http://gateway.library.uiuc.edu/chx/crcflame.pdf 4. resize the mozilla larger result: the plugin in browser keeps the same size as before It is due to gtksocket grabs ConfigWindow event and I have a workaround patch for that.
Attached patch workaround patchSplinter Review
who should r/sr this patch ?
Attachment #119793 - Flags: review?(blizzard)
Can't we listen for the resize events on the socket instead of messing with the X attributes?
Guess what? xembed plugins don't resize properly, either. Fix attached. SetWindow needs to resize the plug when it's called.
Attachment #133874 - Flags: review?(robin.lu)
Comment on attachment 133874 [details] [diff] [review] fix problems with resizing xembed plugins I don't have a resizable xembed plugin to test the patch. But the patch seems OK with me. For the non-xembed plugins, I have to say that my patch is a workaround. Till now, I found the resize problem is due to in both displays ( the one of mozilla and the other created by xtbin) the embeder window selects SubstructureRedirectMask. Then, no matter which side calls XMoveResizeWindow, a ConfiguRequest event will be generated and sent to the other side without the actual resize happened just like playing pingpong. I tried to unselect the mask from the xt side but failed, so I did it in the gtksocket side. Can you help me to find a better way?
Attachment #133874 - Flags: review?(robin.lu) → review+
Yeah, let me look at code for a while.
Attachment #133874 - Flags: approval1.6a?
Comment on attachment 133874 [details] [diff] [review] fix problems with resizing xembed plugins a=asa (on behalf of drivers) for checkin to 1.6alpha
Attachment #133874 - Flags: approval1.6a? → approval1.6a+
Attachment #133874 - Flags: superreview?(bryner)
Comment on attachment 133874 [details] [diff] [review] fix problems with resizing xembed plugins >Index: nsPluginNativeWindowGtk2.cpp >=================================================================== >RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginNativeWindowGtk2.cpp,v >retrieving revision 1.3 >diff -u -r1.3 nsPluginNativeWindowGtk2.cpp >--- nsPluginNativeWindowGtk2.cpp 17 Oct 2003 19:32:28 -0000 1.3 >+++ nsPluginNativeWindowGtk2.cpp 22 Oct 2003 19:45:55 -0000 >@@ -116,17 +117,21 @@ > ((nsPluginInstanceVariable)NPPVpluginNeedsXEmbed, &val); > } > #ifdef DEBUG >- printf("nsPluginNativeWindowGtk2: NPPVpluginNeedsXEmbed=%d\n", &val); >+ printf("nsPluginNativeWindowGtk2: NPPVpluginNeedsXEmbed=%d\n", val); > #endif > if(val) { > CreateXEmbedWindow(); > } >- if(mGtkSocket) >+ >+ if(mGtkSocket) { >+ // Make sure to resize and re-place the window if required >+ SetAllocation(); > window = (nsPluginPort *)gtk_socket_get_id(GTK_SOCKET(mGtkSocket)); >+ } > #ifdef DEBUG >- printf("nsPluginNativeWindowGtk2: call SetWindow with xid=%p\n", window); >+ printf("nsPluginNativeWindowGtk2: call SetWindow with xid=%p\n", (void *)window); > #endif >- aPluginInstance->SetWindow(this); >+ aPluginInstance->SetWindow(this); I think the indentation level of these two lines should stay the same, since the file uses 2-space indentation.
Attachment #133874 - Flags: superreview?(bryner) → superreview+
Attached patch final patchSplinter Review
Final patch for bryner's comments.
Attachment #133874 - Attachment is obsolete: true
OK, my patch is checked in now.
Attachment #119793 - Flags: review?(blizzard)
Hi ! I'm from bug #243710. I see problems in GFX gtk2 not in firefox already. So, in addition on bug's talk. Debian distro firefox maintainer said that there's no such behaviour noticed. Yes maybe it's my local gtk2/gnome2 config problems, but it obvious, that resizing problems are in gtk2-xft-mozilla on linux. If You say that there's no problem with mozilla resize applet(right bottom conner, NO window mnager's one) on X window gtk* linux , that is very unlikely as for me! Thanks !
I am seeing this bug with the acrobat plugin in FireFox 1.0 on Fedora Core 3. You open a .pdf file and if you make the browser window bigger the plugin area of the window doesn't get any bigger.
Is this the same problem as the one described here: http://bugzilla.mozdev.org/show_bug.cgi?id=7734
I suspect that using version 5.0.10 of the adobe plugin will fix this. Please try the most recent version of the plugin.
It may or may not; I'll try later, but you do realise that this is a problem with several different plugins, right?
This problem is in the browser (on both platforms, 1.7 and Firefox) and is not any of the plugin's fault.
QA Contact: bmartin → plugins
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: