201158 - [gtk2]can not resize plugin properly

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Robin Lu]

1. install plugin for pdf from acrobat
2. lanch mozilla and do not resize it to maxim size.
3. open a link of pdf file, for example
http://gateway.library.uiuc.edu/chx/crcflame.pdf
4. resize the mozilla larger

result:
the plugin in browser keeps the same size as before

It is due to gtksocket grabs ConfigWindow event and I have a workaround patch
for that.

Comment 1

[Robin Lu]

Attachment: workaround patch

Comment 2

[Olivier Cahagne]

who should r/sr this patch ?

Comment 3

[Christopher Blizzard (:blizzard)]

Can't we listen for the resize events on the socket instead of messing with the
X attributes?

Comment 4

[Christopher Blizzard (:blizzard)]

Attachment: fix problems with resizing xembed plugins

Guess what?  xembed plugins don't resize properly, either.  Fix attached.

SetWindow needs to resize the plug when it's called.

Comment 5

[Robin Lu]

Comment on attachment 133874 [details] [diff] [review]
fix problems with resizing xembed plugins

I don't have a resizable xembed plugin to test the patch. But the patch seems
OK with me.

For the non-xembed plugins, I have to say that my patch is a workaround. Till
now, I found the resize problem is due to in both displays ( the one of mozilla
and the other created by xtbin) the embeder window selects
SubstructureRedirectMask. Then, no matter which side calls XMoveResizeWindow, a
ConfiguRequest event will be generated and sent to the other side without the
actual resize happened just like playing pingpong. I tried to unselect the mask
from the xt side but failed, so I did it in the gtksocket side. Can you help me
to find a better way?

Comment 6

[Christopher Blizzard (:blizzard)]

Yeah, let me look at code for a while.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 133874 [details] [diff] [review]
fix problems with resizing xembed plugins

a=asa (on behalf of drivers) for checkin to 1.6alpha

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 133874 [details] [diff] [review]
fix problems with resizing xembed plugins

>Index: nsPluginNativeWindowGtk2.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginNativeWindowGtk2.cpp,v
>retrieving revision 1.3
>diff -u -r1.3 nsPluginNativeWindowGtk2.cpp
>--- nsPluginNativeWindowGtk2.cpp	17 Oct 2003 19:32:28 -0000	1.3
>+++ nsPluginNativeWindowGtk2.cpp	22 Oct 2003 19:45:55 -0000
>@@ -116,17 +117,21 @@
>                ((nsPluginInstanceVariable)NPPVpluginNeedsXEmbed, &val);
>     }
> #ifdef DEBUG
>-    printf("nsPluginNativeWindowGtk2: NPPVpluginNeedsXEmbed=%d\n", &val);
>+    printf("nsPluginNativeWindowGtk2: NPPVpluginNeedsXEmbed=%d\n", val);
> #endif
>     if(val) {
>       CreateXEmbedWindow();
>     }
>-    if(mGtkSocket) 
>+
>+    if(mGtkSocket) {
>+      // Make sure to resize and re-place the window if required
>+      SetAllocation();
>       window = (nsPluginPort *)gtk_socket_get_id(GTK_SOCKET(mGtkSocket));
>+    }
> #ifdef DEBUG
>-    printf("nsPluginNativeWindowGtk2: call SetWindow with xid=%p\n", window);
>+      printf("nsPluginNativeWindowGtk2: call SetWindow with xid=%p\n", (void *)window);
> #endif
>-    aPluginInstance->SetWindow(this);
>+      aPluginInstance->SetWindow(this);

I think the indentation level of these two lines should stay the same, since
the file uses 2-space indentation.

Comment 9

[Christopher Blizzard (:blizzard)]

Attachment: final patch

Final patch for bryner's comments.

Comment 10

[Christopher Blizzard (:blizzard)]

OK, my patch is checked in now.

Comment 11

[olecom]

Hi ! I'm from bug #243710. I see problems in GFX gtk2 not in firefox already.
So, in addition on bug's talk.

Debian distro firefox maintainer said that there's no such behaviour noticed.
Yes maybe it's my local gtk2/gnome2 config problems, but it obvious, that
resizing problems are in gtk2-xft-mozilla on linux.
If You say that there's no problem with mozilla resize applet(right bottom
conner, NO window mnager's one) on X window gtk* linux , that is very unlikely
as for me!
Thanks !

Comment 12

[William Bardwell]

I am seeing this bug with the acrobat plugin in FireFox 1.0 on
Fedora Core 3.  You open a .pdf file and if you make the browser
window bigger the plugin area of the window doesn't get any
bigger.

Comment 13

[Toralf Lund]

Is this the same problem as the one described here:

http://bugzilla.mozdev.org/show_bug.cgi?id=7734

Comment 14

[Christopher Blizzard (:blizzard)]

I suspect that using version 5.0.10 of the adobe plugin will fix this.  Please
try the most recent version of the plugin.

Comment 15

[Toralf Lund]

It may or may not; I'll try later, but you do realise that this is a problem
with several different plugins, right?

Comment 16

[William Bardwell]

This problem is in the browser (on both platforms, 1.7 and Firefox) and is not
any of the plugin's fault.