201207 - Need to handle WM_PRINTCLIENT message

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[nws]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02
Build Identifier: mozilla trunk

Currently, the nsWindow object for windows does not handle the WM_PRINTCLIENT
message.    This is needed in order to support some windows functions, like
AnimateWindow().

Reproducible: Always

Steps to Reproduce:

Comment 1

[nws]

Attachment: nsWindow patch

Attaching this patch as a starting point (seems to do the trick).

Comment 2

[Adam Lock]

-> Rod

Comment 3

[Adam Lock]

Reassign properly

Comment 4

[Kevin McCluskey (gone)]

FYI: Rod doesn't work on printing anymore.

taking.

Comment 5

[Michael Krause]

Would it be possible to handle WM_PRINT as well?
Here is my Python code which captures IE window contents just fine.
The Mozilla ActiveX Control returns black pixels.

Thanks in advance,
Michael Krause

Here is the snippet I am using:
    def GetScreenDataHwnd(self, filename, hwnd=None):
        if not hwnd:
            hwnd = self.ie.GetSafeHwnd()
            hwnd = win32gui.FindWindowEx(hwnd, 0, self.windowClass, None)
        dc = win32gui.GetWindowDC(hwnd)
        dc = win32ui.CreateDCFromHandle(dc)
        left, top, right, bottom = win32gui.GetWindowRect(hwnd)
        w = right - left
        h = bottom - top
        hdcMem = dc.CreateCompatibleDC()
        bitmap = win32ui.CreateBitmap()
        bitmap.CreateCompatibleBitmap(dc, w, h);    
        hold = hdcMem.SelectObject(bitmap)
        win32gui.SendMessage(hwnd, WM_PRINT, hdcMem.GetSafeHdc(),
                             PRF_CHILDREN | PRF_CLIENT | PRF_ERASEBKGND | PRF_NONCLIENT | PRF_OWNED)
        hdcMem.SelectObject(hold)
        bitmap.SaveBitmapFile(hdcMem, filename)

Comment 6

[Kevin McCluskey (gone)]

Attachment: Cosmetic cleanup of previous patch. Fixed, tabs, coding conventions etc.

Comment 7

[kinmoz]

Comment on attachment 120133 [details] [diff] [review]
Cosmetic cleanup of previous patch. Fixed, tabs, coding conventions etc.

sr=[e-mail]

Comment 8

[Kevin McCluskey (gone)]

Attachment: removed WM_PRINT case. It is handled by the default window proc

Comment 9

[Kevin McCluskey (gone)]

Comment on attachment 120489 [details] [diff] [review]
removed WM_PRINT case. It is handled by the default window proc

John can you review? Thanks!

Comment 10

[John Keiser (jkeiser)]

Comment on attachment 120489 [details] [diff] [review]
removed WM_PRINT case. It is handled by the default window proc

Yep, that does it.

Comment 11

[Kevin McCluskey (gone)]

Fix checked into trunk.