201248 - Filter/Junk Mail log should honour date-and-time notation format used in OS

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Constantine A. Murenin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.3) Gecko/20030312

The date-and-time notation in the filter log is incorrect. Mozilla uses PM and
AM (the American notation), not used in almost the whole civilised world (except
for the USA). In the operating system the date and time format is set to
yyyy-MM-dd and HH:mm:ss respectively. The date-and-time notation in other
Mozilla components (including mail) seems to be correct. 

Reproducible: Always

Steps to Reproduce:
1. If you have selected 'US' in the 'Regional and Language Options', then change
the date and time format to yyyy-MM-dd and HH:mm:ss respectively. 
2. Enable filter log. 
3. Run filters; see the results in the filter log with the incorrect
date-and-time notation. 
Actual Results:  
Filter log: 
"Applied filter "blah-blah" to message from blah-blah-blah - blah at 04/07/2003
09:41 AM
Action = Move to folder imap://user@server/INBOX/folder
 id = [e-mail]"

Expected Results:  
Filter log: 
"Applied filter "blah-blah" to message from blah-blah-blah - blah at 2003-04-07
09:41
Action = Move to folder imap://user@server/INBOX/folder
 id = [e-mail]"

Comment 1

[Constantine A. Murenin]

*** Bug 201249 has been marked as a duplicate of this bug. ***

Comment 2

[Constantine A. Murenin]

This bug prevents me from testing the filter log feature of the mail-client. 

Comment 3

[Constantine A. Murenin]

Attachment: Filter log not honouring date-and-time notation.

Comment 4

[Constantine A. Murenin]

Verified bug on FreeBSD build. 
OS: All. 

Comment 5

[Constantine A. Murenin]

I assume, we need to change these lines: 


<http://lxr.mozilla.org/mozilla/source/mailnews/base/search/src/nsMsgFilter.cpp#366>

366     rv = aMsgHdr->GetDate(&date);
367     PRExplodedTime exploded;
368     PR_ExplodeTime(date, PR_LocalTimeParameters, &exploded);
369     PR_FormatTimeUSEnglish(dateStr, 100, "%m/%d/%Y %I:%M %p", &exploded);

<http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsSpamSettings.cpp#467>

466   rv = aMsgHdr->GetDate(&date);
467   PRExplodedTime exploded;
468   PR_ExplodeTime(date, PR_LocalTimeParameters, &exploded);
469   PR_FormatTimeUSEnglish(dateStr, 100, "%m/%d/%Y %I:%M %p", &exploded);


It is also kind of odd that we do not test rv status... 

Comment 6

[OstGote!]

Why is this bug still UNCONFIRMED?

Comment 7

[Jungshik Shin]

confirming and taking

Comment 8

[Constantine A. Murenin]

(In reply to comment #7)
> confirming and taking

Please, take a look at patch #124918, from bug #207550, as it is related and
should be applied to fix the hard-coded localisation strings. 

Comment 9

[Constantine A. Murenin]

Attachment: ISO8601-compliance patch

This is a temporary patch, until bug #207550 is resolved. It uses ISO8601
notation for Date and Time, also known as SQL date string (YYYY-MM-DD
HH:MM:SS). I also added seconds, since log-files must be rather accurate.

Comment 10

[Constantine A. Murenin]

Comment on attachment 142889 [details] [diff] [review]
ISO8601-compliance patch

The advantages of the ISO 8601 notation can be found here:
<http://www.cl.cam.ac.uk/~mgk25/iso-time.html> (A Summary of the International
Standard Date and Time Notation).

(It is a good-enough compromise for both American and European users.)

Comment 11

[Simon Montagu :smontagu]

Comment on attachment 142889 [details] [diff] [review]
ISO8601-compliance patch

r=smontagu, but please add a comment repeating what you say in comment 9 before
checking in.

Comment 12

[David :Bienvenu]

Comment on attachment 142889 [details] [diff] [review]
ISO8601-compliance patch

sure, moa=bienvenu

Comment 13

[chris hofmann]

Comment on attachment 142889 [details] [diff] [review]
ISO8601-compliance patch

a=chofmann for 1.7b

Comment 14

[Constantine A. Murenin]

Comment on attachment 142889 [details] [diff] [review]
ISO8601-compliance patch

Checked in by neil on 2004-03-12 15:53 PST.

Comment 15

[Simon Montagu :smontagu]

Fixed by the checkin to bug 207550