201323 - Not packaging nsIImageDocument

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[[e-mail]]

OK, so this is a wild guess at a component.
I noticed that nsIImageDocument isn't in Components.interfaces, nor does an
xpt_dump find it. This means that [object ImageDocument] isn't able to expose
its imageResizingEnabled property to script, so that the context image resizing
menuitem doesn't work, instead generating the following strict warning:
Warning: reference to undefined property _content.document.imageResizingEnabled
Source File: chrome://communicator/content/nsContextMenu.js
Line: 140
Steps to reproduce problem:
1. Turn on automatic image resizing
2. Open a large image. Note that it automatically resizes
3. Right-click the image.
Expected results: "Fit Image to Window" menuitem checked
Actual results: No "Fit Image to Window" menuitem

Comment 1

[hacker formerly known as [e-mail]]

The problem is that someone in layout is clobbering the .xpt file that's being
generated.  .xpts are named after the XPIDL_MODULE which is set in the Makefile.
 If XPIDL_MODULE isn't set, then MODULE is used.  After some fun with find,
xargs & grep, I see that both mozilla/content/html/document/public/Makefile.in &
mozilla/content/xml/document/public/Makefile.in set MODULE=content but do not
set XPIDL_MODULE. They will both generate content.xpt from their list of
XPIDLSRCS.  Whomever gets compiled last wins.  

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Here's a possible (untested) patch.  I didn't add anything to embedding
manifests because I don't know under what conditions we should be adding xpt
files to the embedding manifests, and I don't see how embedders would need
these xpts.  Or should we just ship them anyway?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 119975 [details] [diff] [review]
patch

sr=jst

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-04-09 14:16 PDT.

Comment 6

[Jan Varga [:janv]]

*** Bug 191064 has been marked as a duplicate of this bug. ***

Comment 7

[Chris Petersen]

Verified in the 2003-04-22-08 win32 trunk builds.