201326 - Rhino should be able to coerce JavaScript Date to Java Date

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Hannes Wallnoefer]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Rhino 1.5R4

Rhino does not coerce JavaScript Date objects to Java Date objects when calling
Java methods that take java.util.Date as parameter. I think that coercion would
be both quite simple and useful.

Reproducible: Always

Steps to Reproduce:
js> var d = new Date();
js> var f = new java.text.SimpleDateFormat();
js> f.format(d);
js: "<stdin>", line 18: uncaught JavaScript exception:
java.lang.IllegalArgumentException: Cannot format given Object as a Date

Comment 1

[Phil Schwartau]

cc'ing Igor -

Comment 2

[Hannes Wallnoefer]

Attachment: patch to convert NativeDate to java.util.Date

I've found the problem fairly easy to fix. This patch works well for me, would
be nice if it was applied to CVS.

Comment 3

[Igor Bukanov]

Attachment: Modification of Hannes patch for speed and code size

The patch changes includes the new DataClass field in ScriptRuntime to use it
in NativeJavaObject, a direct access method to NativeDate time and if-sequence
optimization in coerceType.

Comment 4

[Igor Bukanov]

I commited the above patch:

js> var d = new Date();
js> var f = new java.text.SimpleDateFormat();
js> f.format(d);
4/12/03 12:49 PM

Comment 5

[Phil Schwartau]

Verified FIXED:

------------------------------ BEFORE ------------------------------
js> var d = new Date();
js> var f = new java.text.SimpleDateFormat();
js> f.format(d);
js: "<stdin>", line 3: uncaught JavaScript exception:
java.lang.IllegalArgumentException: Cannot format given Object as a Date

------------------------------ AFTER -------------------------------
js> var d = new Date();
js> var f = new java.text.SimpleDateFormat();
js> f.format(d);
4/12/03 6:14 PM

Comment 6

[Igor Bukanov]

Targeting as resolved against 1.5R5