2013889 - Add 'head_ref' to standard V2 index routes for projects using Git

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

For projects running against Github, tasks should use separate index routes across branches. E.g, we don't want builds from the main branch overwriting builds from the release branch.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2013889 - [ci] Add 'head_ref' to standard index routes for Git-based projects, r?#taskgraph-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8f3163a0fe4d
https://hg.mozilla.org/integration/autoland/rev/c13c384ca384
[ci] Add 'head_ref' to standard index routes for Git-based projects, r=taskgraph-reviewers,jcristau

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c13c384ca384

Comment 4

[Julien Cristau [:jcristau]]

We might want to massage the branch/tag names in the index to ensure the route only contains valid characters (https://docs.taskcluster.net/docs/reference/core/index#valid-characters)?

Comment 5

[Andrew Halberstadt [:ahal]]

Good point. From a glance, I think / is the only character supported in Git branches but not TC indexes. For now I'll just replace it with %2F.. though I was musing if we should just url-encode every route all the time. But that's a bigger change for another bug.

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2013889 - Sanitize '/' out of Git routes that use 'head_ref', r?#taskgraph-reviewers!

This character is not allowed in TC routes.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b120a9bff46
https://hg.mozilla.org/integration/autoland/rev/ee0edd94f19b
Sanitize '/' out of Git routes that use 'head_ref', r=taskgraph-reviewers,jcristau

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ee0edd94f19b