201423 - Crash [@ nsWebShell::Create] if urildr.dll is missing

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[timeless]

Comment 1

[Dave Miller [:justdave]]

Build ID  	2003022404
Trigger Time  	2003-04-09 16:55:10
Platform 	Win32
Operating System 	Windows NT 5.0 build 2195
Module 	docshell.dll
URL visited 	no urildr.dll
User Comments 	
Trigger Reason 	Access violation
Source File Name 	c:/builds/seamonkey/mozilla/docshell/base/nsWebShell.cpp
Trigger Line No. 	1233
Stack Trace 	
nsWebShell::Create [c:/builds/seamonkey/mozilla/docshell/base/nsWebShell.cpp,
line 1233]
nsWebShellWindow::Initialize
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp, line 330]
nsAppShellService::JustCreateTopWindow
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 824]
nsAppShellService::CreateHiddenWindow
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 447]
main1 [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1222]
main [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1639]
WinMain [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1660]
WinMainCRTStartup()
KERNEL32.DLL + 0x7903 (0x77e87903) 

Comment 2

[Boris Zbarsky [:bzbarsky]]

  // HACK....force the uri loader to give us a load cookie for this
webshell...then get it's
  // doc loader and store it...as more of the docshell lands, we'll be able to
get rid
  // of this hack...
  nsCOMPtr<nsIURILoader> uriLoader = do_GetService(NS_URI_LOADER_CONTRACTID);
  uriLoader->GetDocumentLoaderForContext(NS_STATIC_CAST(nsIWebShell*, this),
                                         getter_AddRefs(mDocLoader));

That would be the culprit...

Comment 3

[Adam Lock]

The uriloader is statically linked into docshell and has been since Doug checked
in bug 194240.

Is this a problem with a duff registry?

Comment 4

[timeless]

Attachment: this can fail for OOM and other cases.

Comment 5

[Adam Lock]

Comment on attachment 120071 [details] [diff] [review]
this can fail for OOM and other cases.

r=adamlock

Comment 6

[timeless]

checked in