Closed Bug 201577 Opened 22 years ago Closed 22 years ago

[FIX]inDOMView::SetRootNode does not handle the root being a document

Categories

(Other Applications :: DOM Inspector, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.4beta

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

In particular, the ownerDocument of a document node is null. Patch coming.
Priority: -- → P1
Summary: inDOMView::SetRootNode does not handle the root being a document → [FIX]inDOMView::SetRootNode does not handle the root being a document
Target Milestone: --- → mozilla1.4beta
Attached patch Proposed patchSplinter Review
Attachment #120149 - Flags: superreview?(peterv)
Attachment #120149 - Flags: review?(timeless)
Blocks: 156072
Attachment #120149 - Flags: superreview?(peterv) → superreview+
Comment on attachment 120149 [details] [diff] [review] Proposed patch domDoc and mRootDocument appear to be the same type, so unless there's some reason for the local variable, i'd just use mRootDocument :)
Attachment #120149 - Flags: review?(timeless) → review+
fixed.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
vrfy fixed: mozilla/extensions/inspector/base/src/inDOMView.cpp 1.16
Status: RESOLVED → VERIFIED
Product: Core → Other Applications
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: