201624 - remove nsScrollingView and widget nsScrollbar implementations

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Brian Ryner (not reading)]

We can remove nsScrollingView now that support for nsScrollFrame has been
removed.  There is one place I'm not sure about... it's used in:

http://lxr.mozilla.org/seamonkey/source/layout/html/tests/table/TableContentTest/TableContentTest.cpp#486

I suspect that test is not functional, but supposing it was, how would we fix it?

We can also remove the various widget implementations of nsIScrollbar.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't know if that test is functional, but it doesn't appear to rely on the
view being a true native-scrollbars scrolling view. Just replace it with
nsScrollPortView.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That test is using things that haven't existed for years (nsIContentDelegate),
and isn't part of the build.

Comment 3

[Brian Ryner (not reading)]

Attachment: patch

remove nsIScrollbar + implementations and nsScrollingView.  Also removed an
unused file in widget/public.  I've tested that this builds and runs on
windows, mac, and linux.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 121161 [details] [diff] [review]
patch

Ahhh, this makes me feel good.

Are you going to collect seperate MOA for each GFX module? I say you don't need
to bother. At least you're only deleting code.

Comment 5

[Brian Ryner (not reading)]

This was checked in; forgot to close the bug.