201866 - spellcheck should not check quoted text (plain text compose)

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Calum Mackay]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030412
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4b) Gecko/20030412

Bug 173046 fixed the spellchecker to not spellcheck quoted text, since you don't
really want, by default - to spellcheck text you didn't write. This fix only
applied to html mail compose.

This bug is being logged to request a fix for plain text compose.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Kathleen :Brade]

This isn't a composer bug; it's a mail bug  -->

Comment 2

[Todd]

Hi All,

    I just checked out Netscape 7.1's spell checker XPI in 1.4 general release.
And, it works.  Doesn't check quoted text either. 

  
ftp://ftp.netscape.com/pub/netscape7/english/7.1/windows/win32/jgksyc/spellchk.xpi

--Tony

p.s. checking quoted text makes us all look rather amateurish to our customers.
This band-aid will help us all save face until this bugs FINALLY gets fixed

Comment 3

[Scott MacGregor]

I care about this for thunderbird. re-assigning. Maybe JF can show me how easy
it is to add a wrapper tag around quoted plain text replies which the spell
check engine can key off of. 

Comment 4

[Scott MacGregor]

*** Bug 214505 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Kaply [:mkaply]]

How can 7.1 do this?

That implies the spellchecker knows that it is quoted text...

anyone want to look at the NS source code? :)

Comment 6

[kinmoz]

The spellchecker knows nothing about skipping ... it's a filter registered on
the TextServices module ... the one used by Composer/Mail's spellchecker lives in:

   mozilla/editor/composer/src/nsComposeTxtSrvFilter.cpp

Comment 7

[Scott MacGregor]

Mike 7.1 does not skip replies to plain text compose either. This is an open bug
that needs to be fixed. Which is why I assigned it to myself. We have to do some
work in plain text compose to make this techincally possible. 

Comment 8

[Todd]

Hi Scott,

   Check out (my) comment #2.  My Netscape 7.1 spell checker does indeed skip
plain text quoted messages.  Have you tested it lately?  Maybe you are using 
Mozilla 1.5 alpha?

--Tony

Comment 9

[Scott MacGregor]

Are you sure you were not inside an HTML editor instance? Using NS7.1 with the
spell checker with plain text does not work for me. You must have the Use HTML
compose checkbox turned off in Account Settings for the account you are replying
from to truly be in plain text compose.

I can assure you from working "on the other side" that this code does not exist
at all. We need to wrap plain text replies just like HTML compose does with the
block=cite tag to make editor skip over these elements before handing the text
off to the compose window.

Anyway arguing about that is moot and has no bearing on the fact that we want to
fix this and I'm planning on doing so for Thunderbird.

Let's focus on the fix. 

Comment 10

[Scott MacGregor]

I have a fix for this feature. 

Kin, it turns out editor already wraps quoted material for plain text with a pre
or a span tag:
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/html/nsHTMLDataTransfer.cpp#1944

and editor sets a value of _moz_quote="true" on the pre or the span attribute.

I thought I was going to have to write code to wrap plain text quoted material
in a tag.

Knowing this made the rest of the bug easy to fix. I added a few more atoms to
nsComposeTxtSrvFilter to check for this additional information.

Patch coming up. 

Comment 11

[Scott MacGregor]

Attachment: the fix for plain text

Comment 12

[kinmoz]

Comment on attachment 128919 [details] [diff] [review]
the fix for plain text 

sr=[e-mail]

==== I'd lose the "Quote" in mPreQuoteAtom and mSpanQuoteAtom, but it's up to
you.

==== Can you line up the comments you added in the .h file?

Comment 13

[Mike Kaply [:mkaply]]

Comment on attachment 128919 [details] [diff] [review]
the fix for plain text 

r=mkaply

same comment as kin :)

Comment 14

[Scott MacGregor]

fixed (with the review comments). 

Comment 15

[Calum Mackay]

Confirmed fixed, 200308081, mailnews & thunderbird, linux/x86.

Comment 16

[Dave Evans]

Does the fix also include *not* checking the "Written by Miscrean Splleler on
Aug 1, 2003" line that it at the front of every reply/forward quote block

Comment 17

[Vedran Miletic]

v

Comment 18

[mozilla3eran]

This bug consistently reoccurs when the Enigmail extension is installed.
Tested on Mozilla 1.5 20030925, Enigmail 0.76.7.0 (http://enigmail.mozdev.org/).

Comment 19

[Shailesh Kochhar]

I still seem to be having this problem in thunderbird 1.5. Is there something that needs to be done to enable the fix?

Comment 20

[Jeffrey Flaker]

I still see this in Version 31.1.2 (packaged in Ubuntu) when replying to plain text emails.  

Spellcheck is checking the whole message.