201879 - RFE - Warning the user that many message windows are going opened due to a double-click when many messages are selected

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Daniele Orlandi]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030314
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030314


When you are selecting many messages in the messages list an you, by mistake or
cause to this bug:

http://bugzilla.mozilla.org/show_bug.cgi?id=91337

a lot of message windows will be opened, apparently without any explicit
limitation eventually clogging the system.

I prose that when "too many" message windows are going to be opened, a dialog
will be shown, warning the user and giving hime the ability to cancel the operation.



Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Daniele Orlandi]

I don't think there's a real dependency on bug #91337, it just makes the problem
a bit more frequent (if you happen to select messages quickly) but I don't know
what your policies on dependencies are.

Comment 2

[Chris Casciano]

Un-scientific testing on my own system shows MS Entourage warns users at 10 or
more messages.

Comment 3

[Joe Infla]

*** Bug 219747 has been marked as a duplicate of this bug. ***

Comment 4

[Seth LaForge]

I'd like to add that I consider this to be an outright bug, not just something
that needs enhancement.  To see why, try selecting a mail folder with a few
thousand messages, select all, and double-click a message.  Thunderbird will sit
there for a few minutes sucking up more and more memory, making the system
unresponsive, and finally crash (or cause something else to crash) when it runs
out of memory.  This is very poor, and fairly easily triggered due to bug 92978.
 I end up triggering the problem around once a week, and it really sucks.

As a solution, I'd propose that if the user is about to open more then 10
windows, pop up a dialog box asking first.  And perhaps completely disallow
opening more than, say, 250 windows.  I can't think of a valid reason somebody
would want to open 250 windows...

Comment 5

[David Grant]

*** Bug 227989 has been marked as a duplicate of this bug. ***

Comment 6

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

->me, hopefully I can fix this tomorrow.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

let's try this again... ->me

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: Patch

I don't know the "proper" way to patch all.js - where to add the Int pref
"mailnews.warn_lots_of_messages" with default value 10.

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: New patch

Patch mailnews/ also

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: Newer patch

Comment 11

[[e-mail]]

Comment on attachment 140384 [details] [diff] [review]
Newer patch

>+  var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService);
You can delete this now you're using InitPrompts() and gPromptService.

>+  if (!gMessengerBundle)
>+      gMessengerBundle = document.getElementById("bundle_messenger");
I think I'd like to see this moved inside the if where you use it.

>+  if ((openWindowWarning != 0) && (numMessages >= openWindowWarning)) {
I think it would be nice if you put > 1 instead of != 0 in case someone enters
a silly value for the preference.

>+openWindowWarningTitle=Confirm
Ideally you should either a) make the title more interesting or b) pass null as
the title parameter (it defaults to "Confirm") although it appears that mscott
has set a precedent... 

Also, you need to patch mailnews/mailnews.js to set the default preference.

Comment 12

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: New newer patch

Made the requested changes, and others as discussed on IRC.

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: Newer newer patch

I added a space to the thunderbird part of the patch somewhere accidentally
before attaching it, so it won't apply.  The only change since attachmetn
#140551 is the removal of that space so that it applies cleanly.

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 15

[Stefan Borggraefe]

*** Bug 240865 has been marked as a duplicate of this bug. ***