201989 - prototype property of predefined error object is neither ReadOnly nor DontDelete

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

The EcmaScript standard in 15.11.7.6 states:

15.11.7.6    NativeError.prototype
The initial value of NativeError.prototype is a NativeError prototype object
(15.11.7.7). Each
NativeError constructor has a separate prototype object.
This property has  the attributes { DontEnum, DontDelete, ReadOnly }.

In Rhino the prototype property has neither of this attributes as a test case
from the following attchment indicates.

Comment 1

[Igor Bukanov]

Attachment: Test case

The test case should print nothing, but instead it indicates failure for each
error object. Note: the test case does not check that prototype is DontEnum

Comment 2

[Igor Bukanov]

Attachment: Fix: use initAsConstructor to initialize Error constructors in NativeGlobal.init

Comment 3

[Phil Schwartau]

Igor, thank you for these tests! I added one for DontEnum, also.
I split them up and added them to JS testsuite as follows:

  mozilla/js/tests/ecma_3/Exceptions/15.11.7.6-001.js   <---DontEnum
  mozilla/js/tests/ecma_3/Exceptions/15.11.7.6-002.js   <---DontDelete
  mozilla/js/tests/ecma_3/Exceptions/15.11.7.6-003.js   <---ReadOnly


All three are currently passing in SpiderMonkey.
In Rhino, only the first one is passing -

Comment 4

[Igor Bukanov]

Attachment: Patch extension to remove unused functionality in IdFunction.java

Since the changes to NatveGlobal removed the only usage of
IdFunction.setFunctionType method outside IdFunction, I extended the patch to
remove setFunctionType and corresponding getFunctionType in IdFunction and use
a simple private boolean field there to mark functions that can be called as
constructors.

Comment 5

[Igor Bukanov]

I committed the above fix.

Comment 6

[Phil Schwartau]

Verified FIXED.

The above testcases now pass in the Rhino shell in compiled and interpreted mode.

Comment 7

[Igor Bukanov]

Targeting as resolved against 1.5R5