2021618 - Geckoview's DelayedInit queue isn't processed till the end if a queued init errors

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Beatriz Rizental]

This https://searchfox.org/firefox-main/source/mobile/shared/components/geckoview/GeckoViewStartup.sys.mjs#406 call throws on my local dev build.

That prevents the DelayedInit queue from being completely flushed. If a new pending init is added to the queue it would be cleared, but it doesn't seem that happens.

Note, this prevents all the InitLater calls from geckoview.js from running and probably other important calls. From my logs, the faulty one is the second queued init (deterministically), so anything queued after it is not running.

I will send a suggested patch fixing this.

Comment 1

[Beatriz Rizental]

Attachment: Bug 2021618 - Keep processing pending inits after failure.r=owlish

Comment 2

[[:owlish] 🦉 PST]

Hi Beatriz, I wonder if turning off browser.crashReports.onDemand pref would solve this issue for you?

Comment 3

[[:owlish] 🦉 PST]

If it doesn't help, can you show us the stacktrace of the crash? Thank you!

Comment 4

[Beatriz Rizental]

Hi Beatriz, I wonder if turning off browser.crashReports.onDemand pref would solve this issue for you?

It doesn't.

If it doesn't help, can you show us the stacktrace of the crash? Thank you!

This is the error I get from the line I pointed to:

Error: Failed to load resource://gre/modules/RemoteSettingsCrashPull.sys.mjs"

Even if we fix this specific error, wouldn't it be better to also catch error on the DelayedInit module? It's doesn't seem ok to let a single error prevent the whole queue from running.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

owlish, could you please check the recent comment with the requested details from Beatriz? Thanks!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patch got reviewed so we can probably remove the needinfo for owlish.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1e60ceea363e
https://hg.mozilla.org/integration/autoland/rev/59986c823292
Keep processing pending inits after failure.r=geckoview-reviewers,ohall

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/59986c823292