202679 - [beos] each cursor change causes a "new" cursor to be created

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Paul]

With every change of the cursor, a "new" cursor is created on the heep.  On some
machines, people have noticed this causing 100% cpu utilization.

patch to follow

Comment 1

[Paul]

Attachment: now uses global array for storing cursors, instead of "new"ing all the time

Comment 2

[Sergei Dolgov]

Nice cacheing!
Only question, is NS_METHOD nsWindow::SetCursor(nsCursor aCursor) really best
place to fill array, or we can do it somewhere earlier?

Do you need review?

Comment 3

[Sergei Dolgov]

One stylish thing may be added, though, in nsBeOSCursors.h

# define NUM_OF_CURSORS 18

in order to ease programmers' life in case of future changes:)

But as we're adding each element separately, not inside loop, it will have 
only mnemonical sense...

Comment 4

[Paul]

Comment on attachment 121096 [details]
now uses global array for storing cursors, instead of "new"ing all the time

The reason I loaded it in SetCursor, was that first, I knew it had to be done
before then, second, I wasn't sure putting it in the constructor would cause
problems.  Plus, this gets called before the first window is shown, so it is
part of the "start-up" :-)

Comment 5

[Paul]

though have the define for the number of cursors would be nice, it is also not needed, as you already pointed out.

Comment 6

[Paul]

oh, and Sergei, to test regxpcom:
in dist/bin

run-mozilla.sh regxpcom

Comment 7

[Sergei Dolgov]

Comment on attachment 121096 [details]
now uses global array for storing cursors, instead of "new"ing all the time

r=[e-mail]

Comment 8

[Paul]

this has been checked in