Closed
Bug 202813
Opened 22 years ago
Closed 22 years ago
OS/2 - Win16 helpers don't work
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file, 1 obsolete file)
|
3.44 KB,
patch
|
jhpedemonte
:
review+
|
Details | Diff | Splinter Review |
We found two problems with win16 helpers.
1. You can't put quotes around the name.
2. If the name goes over 8.3, it won't load. This happens with multiples of the
same name (filename.doc, filename-1.doc, filename-2.doc)
patch coming
|
Assignee | |
Comment 1•22 years ago
|
||
OK, two things.
1. Only put quotes around the name if it needs it (space in the name)
2. Add an OS/2 unique version of CreateUnique. I had to hack it up good and it
makes no sense to leave it in nsLocalFileCommon.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 121200 [details] [diff] [review]
Fix
Doug, what do you think of my moving CreateUnique for OS/2?
Attachment #121200 -
Flags: review?(dougt)
|
|
Assignee | |
Comment 3•22 years ago
|
||
OK, I made this totally OS/2 specific in helpers and didn't touch nsLocalFile.
We salt the name if the app is dos/win
Attachment #121200 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #121200 -
Flags: review?(dougt)
|
|
Assignee | |
Updated•22 years ago
|
Attachment #121205 -
Flags: review?(pedemont)
|
||
Updated•22 years ago
|
Attachment #121205 -
Flags: review?(pedemont) → review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•