202872 - Removal of FunctionObject.findMethods?

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, enhancement)

Description

[Igor Bukanov]

Currently FunctionObject.findMethods is used to search for all methods with the
same name in the given class and returns them as an array. But all places where
this method is used in Rhino expects explicitly or implicitly that there is only
one such method. So the idea is to replace 

static Method[] findMethods(Class clazz, String name)

by 

static Method findSingleMethod(Class clazz, String name)

which will throw an exception if the method is overloaded.

But then findMethods uses a static cache for a method list for the given class
since in few places  findMethods is called many times on the same class but that
is also overkill since in all such places FunctionObject.getMethodList can be
used to get the list and caching with all potential memory leaks can be removed
completely. So the following patch replaces findMethods by

static Method findSingleMethod(Class clazz, String name) ...

The patch removes FunctionObject.findMethods but since it contains comments
 
 // TODO: Make not public

perhaps somebody used the method outside Rhino?

If this is an issue the method can be restored with explicit deprecation but I
would prefer to remove it explicitly if possible.

Comment 1

[Igor Bukanov]

Attachment: Implementation of the proposal

Comment 2

[Igor Bukanov]

I commited the patch as is, if somebody uses findMethods, then 

cvs diff -r  1.52 -r  1.53 FunctionObject.java

can be used to put it back as a deprecated method.

Comment 3

[Phil Schwartau]

Checkin verified -

Comment 4

[Igor Bukanov]

Targeting as resolved against 1.5R5