Closed
Bug 203167
Opened 22 years ago
Closed 22 years ago
Clean up nsDeckFrame a little
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.5alpha
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
Details
Attachments
(2 files)
|
11.71 KB,
patch
|
peterv
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
|
8.22 KB,
patch
|
Details | Diff | Splinter Review |
Looking at how nsDeckFrame works I noticed that CreateWidget and CreateWidgets
are dead code, and the overrides not needed. Also cleaning up some whitespace.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Comment 2•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #121516 -
Flags: superreview?(bryner)
Attachment #121516 -
Flags: review?(peterv)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 121516 [details] [diff] [review]
Clean up nsDeckFrame.cpp
>Index: nsDeckFrame.cpp
>===================================================================
>+ // Make sure we tweek the state so it does not resize our children.
tweak
Attachment #121516 -
Flags: review?(peterv) → review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 121516 [details] [diff] [review]
Clean up nsDeckFrame.cpp
sr=me
Attachment #121516 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 6•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You forgot to check in the .h file, but I just did, since the patch was in the bug.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•