203422 - fix some build warnings in netwerk

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Jonathan Wilson]

fix some warnings in netwerk (aka neko) which might be indicative of potential
problems.

Comment 1

[Boris Zbarsky [:bzbarsky]]

*** Bug 203423 has been marked as a duplicate of this bug. ***

Comment 2

[Jonathan Wilson]

Attachment: (Av1) patch

patch to fix warnings

If this patch is good, I will fix more similar warnings in other parts of the
code (e.g. mailnews)

Comment 3

[Darin Fisher]

Comment on attachment 121766 [details] [diff] [review]
(Av1) patch

>Index: netwerk/streamconv/converters/nsBinHexDecoder.cpp

>-			if ((val = BHEXVAL(c)) == -1) 
>+                        if ((val = BHEXVAL(c)) == PRUint32(-1)) 
> 			{

stick with tabs here even though the file seems to use them inconsistently.


>Index: netwerk/dns/src/nameprep.c

> 	MAKE_NAMEPREP_HANDLE("nameprep-11", id11),
>-	{ NULL, NULL, NULL },
>+        { NULL, NULL, NULL, NULL, NULL },

again, remember to conform to the indentation style of the file you
are modifying.


>Index: netwerk/dns/src/race.c

> 	int bitlen = 0;
>-	int i, j;
>+        unsigned int i, j;
> 	size_t len;

same indentation nit.


sr=me with these nits addressed.

Comment 4

[Jonathan Wilson]

Attachment: (Av1b) patch v2

Fixed tab stuff

Comment 5

[Darin Fisher]

Comment on attachment 122389 [details] [diff] [review]
(Av1b) patch v2

sr=darin

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 122389 [details] [diff] [review]
(Av1b) patch v2


'approval1.6=?': Trivial code cleanup.
(if not too late)

Comment 7

[Andreas Otte]

Note: some of the fixes in this patch are already in

Comment 8

[Serge Gautherie (:sgautherie)]

I'll post an updated past...

Comment 9

[Andreas Otte]

Attachment: (Av2) updated patch for reference

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Av2b) updated and enhanced patch [Check in: See (Av2c)]

Comment 11

[Darin Fisher]

Comment on attachment 137621 [details] [diff] [review]
(Av2b) updated and enhanced patch
[Check in: See (Av2c)]

>Index: mozilla/netwerk/streamconv/converters/nsBinHexDecoder.cpp

>-			if ((val = BHEXVAL(c)) == -1) 
>+      if ((val = BHEXVAL(c)) == PRUint32(-1))
> 			{

nit: fix indentation to be consistent (i.e., looks like you need
to use tabs).

sr=darin with that nit picked

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Av2c) updated and enhanced patch [Checked in: Comment 13]

Av2b, with comment 11 suggestion(s).

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 138560 [details] [diff] [review]
(Av2c) updated and enhanced patch
[Checked in: Comment 13]


Check in: { 01/07/2004 15:43	neil%parkwaycc.co.uk }