203443 - main program icon doesnt get pulled in properly with MingW builds

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jonathan Wilson]

Windres doesnt say anything so I dont know why its not being pulled into the
program properly.

Comment 1

[David G King]

I'd noticed this, but had assumed it had something to do with my
building/running problems. Seems I was wrong.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

-> build config, at a guess

Comment 3

[cls]

-> XP Apps

Comment 4

[hacker formerly known as [e-mail]]

*** Bug 211794 has been marked as a duplicate of this bug. ***

Comment 5

[David G King]

If this is a WINDRES issue, which I'm not sure about, wasn't there going to be a
new release of WINDRES a while back?

Comment 6

[Mathew McBride]

Opened my MingW compiled mozilla.exe in Resource Hacker, and nothing appears.

Comment 7

[Adam Schlag]

The compiled resource file (whatever.res) is not being included when the program
is linked, and therefore is not being included in the compiled executables.  The
flag -mwindows should also be added so the programs are compiled as true Windows
programs (a console window won't appear when the program is run).  I've verified
these both myself by re-building mozilla.exe by hand (just modifying the command
make uses), but don't have the time to change the build system myself.

Comment 8

[Nilson Cain]

I do hope this gets fixed soon, as it's somewhat annoying not havng an icon in
my builds.

Comment 9

[cls]

Attachment: v1.0

Comment 10

[Daniel (Leaf) Nunes]

Comment on attachment 128793 [details] [diff] [review]
v1.0

r=leaf

Comment 11

[cls]

Patch has been checked in.

Comment 12

[Nitin (vfwlkr)]

Works with a 2003-08-04 CVS checkout

Comment 13

[David G King]

I now get an icon when building on Win XP using gcc. However, I don't get an
icon when building Firebird or Thunderbird. Is that the same issue, or should I
file a new bug on that?

Comment 14

[cls]

Probably the same issue but definitely a different bug.  The makefiles for those
products were not updated.

Comment 15

[David G King]

Re my Comment #13.

Icons work for WIN32 Gcc builds of Mozilla, Thunderbird and Firebird as of 23/8/03.

Verifying...