203450 - Missing declaration in security/nss/lib/jar/jarevil.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[tenthumbs]

While building mozilla, gcc says

jarevil.c:345: warning: implicit declaration of function \
  `__CERT_AddTempCertToPerm'

Obviously missing a declaration somewhere.

Comment 1

[Wan-Teh Chang]

Bob, could you take a look at this?  Seems that
we need to add __CERT_AddTempCertToPerm to nssrenam.h
and have jarevil.c include nssrenam.h before including
any other headers (at least before including certdb.h)?

Comment 2

[Robert Relyea]

Sounds like a reasonable thing to do. It's also pretty low priority (lib/jar is
only used for some NSS cmds).

bob

Comment 3

[Robert Relyea]

Attachment: Fix compilier warning in jarevil.c

Implemented Wan-Teh's suggestion

Comment 4

[Wan-Teh Chang]

Comment on attachment 132939 [details] [diff] [review]
Fix compilier warning in jarevil.c

r=wtc.

Comment 5

[Robert Relyea]

Checking in jar/jarevil.c;
/cvsroot/mozilla/security/nss/lib/jar/jarevil.c,v  <--  jarevil.c
new revision: 1.7; previous revision: 1.6
done

Comment 6

[Robert Relyea]

oops missing this cvs log.
cvs commit: Examining jar
Checking in nss/nssrenam.h;
/cvsroot/mozilla/security/nss/lib/nss/nssrenam.h,v  <--  nssrenam.h
new revision: 1.2; previous revision: 1.1

Comment 7

[timeless]

*** Bug 214204 has been marked as a duplicate of this bug. ***