Closed Bug 203450 Opened 21 years ago Closed 21 years ago

Missing declaration in security/nss/lib/jar/jarevil.c

Categories

(NSS :: Libraries, defect, P2)

Product:
NSS
Component:
Libraries
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tenthumbs, Assigned: rrelyea)

References

Details

Attachments

(1 file)

Fix compilier warning in jarevil.c
1.31 KB, patch
wtc
: review+
julien.pierre
: superreview+
Details | Diff | Splinter Review 
While building mozilla, gcc says

jarevil.c:345: warning: implicit declaration of function \
  `__CERT_AddTempCertToPerm'

Obviously missing a declaration somewhere.
Bob, could you take a look at this?  Seems that
we need to add __CERT_AddTempCertToPerm to nssrenam.h
and have jarevil.c include nssrenam.h before including
any other headers (at least before including certdb.h)?
Assignee: wtc → relyea
Priority: -- → P2
Target Milestone: --- → 3.9
Version: unspecified → 3.8
Sounds like a reasonable thing to do. It's also pretty low priority (lib/jar is
only used for some NSS cmds).

bob
Implemented Wan-Teh's suggestion
Attachment #132939 - Flags: superreview?(jpierre)
Attachment #132939 - Flags: review?(wchang0222)
Comment on attachment 132939 [details] [diff] [review]
Fix compilier warning in jarevil.c

r=wtc.
Attachment #132939 - Flags: review?(wchang0222) → review+
Attachment #132939 - Flags: superreview?(jpierre) → superreview+
Checking in jar/jarevil.c;
/cvsroot/mozilla/security/nss/lib/jar/jarevil.c,v  <--  jarevil.c
new revision: 1.7; previous revision: 1.6
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
oops missing this cvs log.
cvs commit: Examining jar
Checking in nss/nssrenam.h;
/cvsroot/mozilla/security/nss/lib/nss/nssrenam.h,v  <--  nssrenam.h
new revision: 1.2; previous revision: 1.1
*** Bug 214204 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: