20366 - Unsuccessful IMAP folder rename makes folder disappear

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[Richard Zach]

If a folder on an IMAP server is renamed, but the rename is not successful, the
folder disappears from the folder pane, only restarting Mozilla brings it back.

To reproduce:
1. Open the messenger
2. Create a new folder named "Test"
3. Select another folder
4. File | Rename folder
5. Enter "Test" and click ok.

Actual result: The name of the renamed folder is removed from the folder pane,
the mail server responds with an error message (folder named "Test" already
exists).

Expected result: The error message should appear before the folder is removed
from the folder list.

Linux build 1999.11.30.08

Comment 1

[Phil Peterson]

Reassign to jefft

Comment 2

[Karen Huang]

I tried on today's 11-30-08-M12 build on Linux.
The IMAP rename worked fine.
I can rename folder successfully wothout exit the application.
Just need to wait for the change to reflect on the folder panel.
Jeff, can you try this for today build?

Comment 3

[Karen Huang]

Based on your test procedures,
I am thinking that the error which you got should be correct
since there was a folder name "Test" which you already created,
and if you want to rename to "Test" again. The error dialog should
display: 'folder named "Test" already exists' which should be correct!!

Comment 4

[Richard Zach]

Yes the error message is correct.  But the name of the folder to be renamed
should not be removed from the folder list before the rename has actually taken
effect on the server.  In other words, what should happen is: send request to
server first, wait for response, then change folder name in folder list.

Comment 5

[jefft]

No doubt about it. The problem exists. If you already have a folder with the
same name you are trying to rename to. It'll fail eventually. However, the old
folder has been removed from the folder pane. You can only get it back when you
relaunch the mail app. The right way to solve the problem is until we get the
rename succeeded response from the server we don't remove the old folder from
the folder view.

Comment 6

[Karen Huang]

It seemed this problem sometimes happened, sometimes not.
I got the error message now....

Comment 7

[jefft]

M14 ....

Comment 8

[jefft]

Partial fix checked in. Still need to work out name conflicts with not 
subscribed folders.

Comment 9

[Ninoschka Baca]

FYI: Build 2000012812M14: Mac 8.5.1
Using an IMAP account, I renamed a folder to a name that is not used by any 
other folder. The folder disappears after renaming it and displays after closing 
and restarting mail. 

I didn't see this problem using Linux or NT so for this build it's only a 
problem on the Mac.

Comment 10

[jefft]

Fix checked in.

Comment 11

[Richard Zach]

Verified on Linux build 2000.03.01.08.  Should this be tested on other
platforms?

Comment 12

[lchiang]

Yes.  Karen (huang) can verify on Mac and Windows.  Thanks, Richard!

Comment 13

[Karen Huang]

Yes. I was trying to reply this message but bugzilla was down at that time...
I will verify on the other platforms. Thanks for the updates.

Comment 14

[Karen Huang]

Verified on all the platforms:
Linux 03-01-08-M15 commercial build
WinNT 03-01-09-M15 commercial build
Mac 03-01-08-M15 commercial build
All work fine now...marking as verified!!