203666 - Clean up nsWindow::FreeNativeData()

Status: RESOLVED DUPLICATE of bug 205825

(Core Graveyard :: GFX: OS/2, defect)

Description

[jhp (no longer active)]

The function FreeNativeData (and the corresponding GetNativeData) need to be
cleaned up on OS/2.  Specifically, FreeNativeData should be calling WinReleasePS
on 'data' rather then 'mPS' (this is probably the cause of some difficult to
recreate font corruption issues).  Also, we probably don't even need to save mPS
here.  Lastly, Win32 calls Get/FreeNativeData in the
nsPluginInstanceOwner::Get/ReleasePluginPort() functions;  should we be going
down the same paths on OS/2?

Comment 1

[Mike Kaply [:mkaply]]

quick fix checked in.

Comment 2

[Mike Kaply [:mkaply]]

nsObjectFrame is going to need more investigation. There is a bit of Windows
specific code in there.

What we need to find is a demo of a windowless plugin that we can test on OS/2.

I have a patch of the FreeNativeData cleanup coming.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Make code more like windows

This is pretty much the Windows code.

I replaced the FreeNativeData in nsDrawingSurface with WinReleasePS(same as
Windows). I'm not convinced this is the right thing to do though. Since the
surface was obtained with GetNativeData in nsRenderingContextOS2, it should
probably be released wiht FreeNativeData for consistency.

What do you think Javier?

Comment 4

[Mike Kaply [:mkaply]]

I like Javier's better

*** This bug has been marked as a duplicate of 205825 ***