Closed
Bug 203796
Opened 22 years ago
Closed 22 years ago
configure faills with test: invalid argument
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: jim.brown, Assigned: mozbugs-build)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
netscape
:
review+
sspitzer
:
approval1.4b+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.2) Gecko/20021205
Build Identifier: Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.2) Gecko/xx -> using current trunk
If I change the -g3 to -g from DEC OSF1 builds then configure fails to run.
If fails when trying to evaluate 'if test ! "-g"' because test is seeing the -g
instead of treating it as simple text.
Reproducible: Always
Steps to Reproduce:
1. Replace the only occurance of -g3 with -g in configure
2. Try to build (with debug) on OSF1
3. configure fails with invalid argument to test
Replace two uses of 'test ! "$var"' with 'test -z "$var"' where $var can
contain a string that looks like an option (e.g. -g). This is a very low risk
change.
There are eight other places this construct is used but the variable's value
should not look like a test option.
Updated•22 years ago
|
Attachment #122014 -
Flags: review+
Updated•22 years ago
|
Attachment #122014 -
Flags: approval1.4b?
Comment 2•22 years ago
|
||
Comment on attachment 122014 [details] [diff] [review]
v1.0 replace test ! "$x" with test -z "$x"
a=sspitzer
Attachment #122014 -
Flags: approval1.4b? → approval1.4b+
Comment 3•22 years ago
|
||
Patch has been checked in.
Status: UNCONFIRMED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.4beta
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•